Recording in UMA when a user interacted with an address form or a credit card form.

components/autofill/core/browser/autofill_metrics.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
 
 #include <stddef.h>
 #include <string>
 
@@ skipping 225 matching lines @@
     USER_DID_AUTOFILL,
     // Same as above, but only logged once per page load.
     USER_DID_AUTOFILL_ONCE,
     // User edited a previously autofilled field.
     USER_DID_EDIT_AUTOFILLED_FIELD,
     // Same as above, but only logged once per page load.
     USER_DID_EDIT_AUTOFILLED_FIELD_ONCE,
     NUM_USER_HAPPINESS_METRICS,
   };
 
+  // Form Events for autofill.
+  // These events are triggered separetly for address and credit card forms.
+  enum AutofillFormEvent {

[Evan Stade, 2015/01/30 19:39:50]

s/Event/Metric to match the other enums here (Event sounds too much like a
struct to me)

[Walter Cacau, 2015/01/30 22:05:56]

Keeping event for now as there seems to be a few other instances in the file.

+    // User interacted with a field of this kind of form. Logged only once per
+    // page load.
+    // TODO(waltercacau): All histograms here seem to start with 0,
+    // but the histogram code seems to expect a minimum of 1. Strangely,
+    // they seem to succeed all the assertions as long as there is more then
+    // one enum value.

[Evan Stade, 2015/01/30 19:39:50]

Ilya^

+    INTERACTED_ONCE = 1,
+    NUM_AUTOFILL_FORM_EVENTS,
+  };
+
   // For measuring the network request time of various Wallet API calls. See
   // WalletClient::RequestType.
   enum WalletApiCallMetric {
     UNKNOWN_API_CALL,  // Catch all. Should never be used.
     ACCEPT_LEGAL_DOCUMENTS,
     AUTHENTICATE_INSTRUMENT,
     GET_FULL_WALLET,
     GET_WALLET_ITEMS,
     SAVE_TO_WALLET,
     NUM_WALLET_API_CALLS
@@ skipping 152 matching lines @@
   // This should be called each time a new profile is launched.
   static void LogIsAutofillEnabledAtStartup(bool enabled);
 
   // This should be called each time a new profile is launched.
   static void LogStoredProfileCount(size_t num_profiles);
 
   // Log the number of Autofill suggestions presented to the user when filling a
   // form.
   static void LogAddressSuggestionsCount(size_t num_suggestions);
 
+  // Utility to autofill form events in the relevant histograms depending on
+  // the presence of server and/or local data.
+  struct FormEventLogger {

[Evan Stade, 2015/01/30 19:39:50]

this should be a class not a struct

[Walter Cacau, 2015/01/30 22:05:56]

Done.

+   public:
+    FormEventLogger(
+        bool is_credit_card,
+        bool is_server_data_available,
+        bool is_local_data_available);
+    void Log(AutofillFormEvent event);

[Evan Stade, 2015/01/30 19:39:50]

missing newline and doc

[Walter Cacau, 2015/01/30 22:05:56]

Done.

+   private:
+    bool is_credit_card_;
+    bool is_server_data_available_;
+    bool is_local_data_available_;
+  };

[Evan Stade, 2015/01/30 19:39:50]

missing newline

[Walter Cacau, 2015/01/30 22:05:56]

Done.

  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(AutofillMetrics);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_