tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 7b2a5f27b5ccf841eb7797fa4a71eaaf56520443..0e32c70cbccf6059afc8809554345eaf86e81f5f 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -1803,6 +1803,80 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="Autofill.FormEvents.Address" enum="AutofillFormEvent">
+  <owner>waltercacau@chromium.org</owner>
+  <summary>Autofill form events for address forms.</summary>
+</histogram>
+
+<histogram name="Autofill.FormEvents.Address.WithBothServerAndLocalData"

[Ilya Sherman, 2015/01/30 05:35:48]

I'd recommend using a <histogram_suffixes> element to reduce the amount of
repetition across these histogram descriptions.

[Walter Cacau, 2015/01/30 05:55:15]

Done.

+    enum="AutofillFormEvent">
+  <owner>waltercacau@chromium.org</owner>
+  <summary>
+    Autofill form events for address forms (both server and local autofill
+    data).
+  </summary>
+</histogram>
+
+<histogram name="Autofill.FormEvents.Address.WithNoData"
+    enum="AutofillFormEvent">
+  <owner>waltercacau@chromium.org</owner>
+  <summary>Autofill form events for address forms (no autofill data).</summary>
+</histogram>
+
+<histogram name="Autofill.FormEvents.Address.WithOnlyLocalData"
+    enum="AutofillFormEvent">
+  <owner>waltercacau@chromium.org</owner>
+  <summary>
+    Autofill form events for address forms (only local autofill data).
+  </summary>
+</histogram>
+
+<histogram name="Autofill.FormEvents.Address.WithOnlyServerData"

[Ilya Sherman, 2015/01/30 05:35:48]

As I mentioned on the doc, I think the local/server/local+server distinction is
probably overkill.  Do you really expect users to interact with the UI
differently depending on the data sources available to them?

At the least, I request that you log a TODO and file a bug to re-evaluate
whether this breakdown is still needed after a few milestones have passed.

[Walter Cacau, 2015/01/30 05:55:15]

That is a fair point. We (me and my team) believe we need it, but as you said we
can always remove them altogether after a few milestones.

So, where should this bug be filed? Any place in particular where I should also
add a TODO? In the code or in the xml? 

[Ilya Sherman, 2015/01/30 22:23:48]

Please file a bug in the Chromium bug tracker, with appropriate labels for
Autofill and the target milestone.  For the TODO, I think it's easiest to
include it in autofill_metrics.cc.

[Walter Cacau, 2015/01/31 00:35:55]

Done.
https://code.google.com/p/chromium/issues/detail?id=454017

+    enum="AutofillFormEvent">
+  <owner>waltercacau@chromium.org</owner>
+  <summary>
+    Autofill form events for address forms (only server autofill data).
+  </summary>
+</histogram>
+
+<histogram name="Autofill.FormEvents.CreditCard" enum="AutofillFormEvent">
+  <owner>waltercacau@chromium.org</owner>
+  <summary>Autofill form events for credit card forms.</summary>
+</histogram>
+
+<histogram name="Autofill.FormEvents.CreditCard.WithBothServerAndLocalData"
+    enum="AutofillFormEvent">
+  <owner>waltercacau@chromium.org</owner>
+  <summary>
+    Autofill form events for credit card forms (both server and local autofill
+    data).
+  </summary>
+</histogram>
+
+<histogram name="Autofill.FormEvents.CreditCard.WithNoData"
+    enum="AutofillFormEvent">
+  <owner>waltercacau@chromium.org</owner>
+  <summary>
+    Autofill form events for credit card forms (no autofill data).
+  </summary>
+</histogram>
+
+<histogram name="Autofill.FormEvents.CreditCard.WithOnlyLocalData"
+    enum="AutofillFormEvent">
+  <owner>waltercacau@chromium.org</owner>
+  <summary>
+    Autofill form events for credit card forms (only local autofill data).
+  </summary>
+</histogram>
+
+<histogram name="Autofill.FormEvents.CreditCard.WithOnlyServerData"
+    enum="AutofillFormEvent">
+  <owner>waltercacau@chromium.org</owner>
+  <summary>
+    Autofill form events for credit card forms (only server autofill data).
+  </summary>
+</histogram>
+
 <histogram name="Autofill.IsEnabled.PageLoad" enum="BooleanEnabled">
   <owner>isherman@chromium.org</owner>
   <summary>
@@ -42765,6 +42839,10 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <int value="17" label="fp05cc03e1"/>
 </enum>
 
+<enum name="AutofillFormEvent" type="int">
+  <int value="1" label="Interected once"/>

[Ilya Sherman, 2015/01/30 05:35:48]

Are you planning to add more events?  Any reason not to add them as part of this
CL?

[Ilya Sherman, 2015/01/30 05:35:48]

nit: Any reason not to start numbering at 0?

[Ilya Sherman, 2015/01/30 05:35:48]

nit: "Interected" -> "Interacted"

[Walter Cacau, 2015/01/30 05:55:15]

Funny story, I have a feeling we have been doing something wrong here because if
I make it start from 0 the histogram code crashes in debug mode (an assertion
fails). For enumerations it seems that the code expect enums to have minimum
value of 1.

[Walter Cacau, 2015/01/30 05:55:15]

Yes I am. I may do it in this CL but I wanted a to that the approach I was
taking seemed reasonable. If it is I can simply add more to this CL.

[Walter Cacau, 2015/01/30 05:55:15]

Done.

[Ilya Sherman, 2015/01/30 22:23:48]

The assertion is only tripped if you try to define an enumerated histogram with
only a single bucket.  The reason for this is that bucket 0 is typically
reserved for underflow in histograms.  However, enumerated histograms don't have
underflow; so most enumerated histograms actually write real data into the
underflow bucket.  The result is that when you have an enumerated histogram with
just a single bucket, it looks like you're defining a histogram that has only
and underflow and an overflow bucket, and nothing else.  This trips an assertion
failure, because it looks like you're defining a histogram with no real buckets.
 Once you add more events, the assertion will no longer be tripped.

+</enum>
+
 <enum name="AutofillMacAddressBook" type="int">
   <int value="0" label="Showed popup entry"/>
   <int value="1" label="Selected popup entry"/>