Recording in UMA when a user interacted with an address form or a credit card form.

components/autofill/core/browser/personal_data_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/personal_data_manager.h"
 
 #include <algorithm>
 #include <functional>
 #include <iterator>
 
@@ skipping 1179 matching lines @@
 }
 
 void PersonalDataManager::EnabledPrefChanged() {
   default_country_code_.clear();
   NotifyPersonalDataChanged();
 }
 
 const std::vector<AutofillProfile*>& PersonalDataManager::GetProfiles(
     bool record_metrics) const {
 #if defined(OS_MACOSX) && !defined(OS_IOS)
-  if (!pref_service_->GetBoolean(prefs::kAutofillUseMacAddressBook))
-    return web_profiles();
+  bool use_auxiliary_profiles =
+      pref_service_->GetBoolean(prefs::kAutofillUseMacAddressBook);
 #else
-  if (!pref_service_->GetBoolean(prefs::kAutofillAuxiliaryProfilesEnabled))
-    return web_profiles();
+  bool use_auxiliary_profiles =
+      pref_service_->GetBoolean(prefs::kAutofillAuxiliaryProfilesEnabled);
 #endif  // defined(OS_MACOSX) && !defined(OS_IOS)
 
   profiles_.clear();
 
   // Populates |auxiliary_profiles_|.
-  LoadAuxiliaryProfiles(record_metrics);
+  if (use_auxiliary_profiles)
+    LoadAuxiliaryProfiles(record_metrics);
 
   profiles_.insert(profiles_.end(), web_profiles_.begin(), web_profiles_.end());

[Evan Stade, 2015/02/03 20:02:11]

couldn't you fix this by changing these web_profiles_ to web_profiles()?

[Walter Cacau, 2015/02/03 20:25:00]

Unfortunately this does not work because test_personal_manager uses profiles_ as
its storage mechanism and we clear it here.

So far I can only see the following alternative options:
1) Change test_personal_manager to have its own _test_profiles variable instead
of it relying on _profiles.
2) Keep the current solution but don't override GetProfiles, just override
GetProfiles(bool). Reasoning: GetProfiles implementation is just
GetProfiles(false).

[Walter Cacau, 2015/02/05 04:00:18]

I was wrong. There is no conflict in the profiles_ because test_personal_manager
also declares a private profile_ member. Did in the original way you suggested.

-  profiles_.insert(
-      profiles_.end(), auxiliary_profiles_.begin(), auxiliary_profiles_.end());
+  if (use_auxiliary_profiles) {
+    profiles_.insert(
+        profiles_.end(), auxiliary_profiles_.begin(),
+        auxiliary_profiles_.end());
+  }
   profiles_.insert(
       profiles_.end(), server_profiles_.begin(), server_profiles_.end());
   return profiles_;
 }
 
 }  // namespace autofill