Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 884813002: Tweak output of (memcheck|drmemory)_analyze.py. (Closed)

Created:
5 years, 10 months ago by earthdok
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tweak output of (memcheck|drmemory)_analyze.py. Wrap error reports in "### (BEGIN|END) MEMORY TOOL REPORT". This will allow us to extract them with GTestLogParser and use them as snippets. BUG=453020 R=thestig@chromium.org NOTRY=true Committed: https://crrev.com/9794e18ce8653e49c1b9f6da0033276a79f88579 Cr-Commit-Position: refs/heads/master@{#313572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M tools/valgrind/drmemory_analyze.py View 1 chunk +6 lines, -1 line 0 comments Download
M tools/valgrind/memcheck_analyze.py View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
earthdok
please take a look
5 years, 10 months ago (2015-01-28 19:51:02 UTC) #1
Lei Zhang
lgtm
5 years, 10 months ago (2015-01-28 20:14:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884813002/1
5 years, 10 months ago (2015-01-28 20:29:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 20:31:12 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9794e18ce8653e49c1b9f6da0033276a79f88579 Cr-Commit-Position: refs/heads/master@{#313572}
5 years, 10 months ago (2015-01-28 20:32:44 UTC) #6
jam
this broke nacl_integration. please don't TBR. there's no reason at all this shouldn't have gone ...
5 years, 10 months ago (2015-01-28 21:56:47 UTC) #7
jam
On 2015/01/28 21:56:47, jam wrote: > this broke nacl_integration. > > please don't use NOTRY=true. ...
5 years, 10 months ago (2015-01-28 21:57:01 UTC) #8
jam
On 2015/01/28 21:56:47, jam wrote: > this broke nacl_integration. > > please don't use NOTRY=true. ...
5 years, 10 months ago (2015-01-28 21:57:02 UTC) #9
jam
5 years, 10 months ago (2015-01-28 21:57:24 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/883073006/ by jam@chromium.org.

The reason for reverting is: broke tree. don't use NOTRY=true again
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29....

Powered by Google App Engine
This is Rietveld 408576698