Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 884793003: Enable distance field text on Android. (Closed)

Created:
5 years, 10 months ago by Jvsquare
Modified:
5 years, 9 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, David Yen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable distance field text on Android. Sets the Android default for Ganesh-rendered text to use signed distance fields. The non-Android default still disables distance fields. BUG=446722 OWNERS=jam@chromium.org Committed: https://crrev.com/58c4e746a47894de46dbfaa978f163d2072df7e0 Cr-Commit-Position: refs/heads/master@{#320272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/renderer/render_thread_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Jvsquare
We should be good to go to finally turn this on. PTAL.
5 years, 10 months ago (2015-02-12 17:01:42 UTC) #2
jvanverth1
If this is desired for M42, someone needs to look at it soon. TIA.
5 years, 10 months ago (2015-02-17 19:11:25 UTC) #4
Jvsquare
Still awaiting a reviewer for this.
5 years, 9 months ago (2015-03-05 17:56:41 UTC) #6
robertphillips
fwiw, lgtm from the Skia perspective
5 years, 9 months ago (2015-03-05 18:02:18 UTC) #8
vmiura
Jim, I was waiting for an update on crbug.com/458791 as DFFs were making that one ...
5 years, 9 months ago (2015-03-05 18:10:48 UTC) #9
Jvsquare
On 2015/03/05 18:10:48, vmiura wrote: > Jim, I was waiting for an update on crbug.com/458791 ...
5 years, 9 months ago (2015-03-05 18:14:34 UTC) #10
jam
rubberstamp lgtm
5 years, 9 months ago (2015-03-05 18:30:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884793003/1
5 years, 9 months ago (2015-03-12 12:52:29 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-12 13:57:44 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/58c4e746a47894de46dbfaa978f163d2072df7e0 Cr-Commit-Position: refs/heads/master@{#320272}
5 years, 9 months ago (2015-03-12 13:58:33 UTC) #15
Jvsquare
5 years, 9 months ago (2015-03-26 12:32:44 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1034153002/ by jvanverth@chromium.org.

The reason for reverting is: Apparently causing significant perf regressions in
thread_times.key_silk_cases..

Powered by Google App Engine
This is Rietveld 408576698