Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 884783004: [Smart Lock] Fix a failing DCHECK (Closed)

Created:
5 years, 10 months ago by Ilya Sherman
Modified:
5 years, 10 months ago
Reviewers:
Tim Song, tengs1
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Fix a failing DCHECK The setup notification title does not have a placeholder string, so don't try to substitute one. BUG=453147 TEST=none R=tengs@chromium.org Committed: https://crrev.com/f61604541419bac129d2cd88b3d42039f6014161 Cr-Commit-Position: refs/heads/master@{#314046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Ilya Sherman
5 years, 10 months ago (2015-01-29 00:42:13 UTC) #1
spang
There's at least one more: IDS_EASY_UNLOCK_SETUP_ERROR_BLUETOOTH_CONNECTION_FAILED
5 years, 10 months ago (2015-01-29 00:45:13 UTC) #2
Ilya Sherman
On 2015/01/29 00:45:13, spang wrote: > There's at least one more: > IDS_EASY_UNLOCK_SETUP_ERROR_BLUETOOTH_CONNECTION_FAILED Hmm, that ...
5 years, 10 months ago (2015-01-29 00:49:20 UTC) #3
tengs1
lgtm
5 years, 10 months ago (2015-01-30 22:33:57 UTC) #5
Tim Song
Sorry, wrong account. LGTM.
5 years, 10 months ago (2015-01-30 23:47:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884783004/1
5 years, 10 months ago (2015-01-31 01:57:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-31 05:45:29 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-01-31 05:46:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f61604541419bac129d2cd88b3d42039f6014161
Cr-Commit-Position: refs/heads/master@{#314046}

Powered by Google App Engine
This is Rietveld 408576698