[GCM] Fixing the initialization of last checkin/fetch time if they are

[GCM] Fixing the initialization of last checkin/fetch time if they are
corrupted/missing in GCM store

BUG=453018
R=zea@chromium.org,miu@chromium.org

Committed: https://crrev.com/37fbf9cda8bcc2b85e537d2d2e4fc0db4749706f
Cr-Commit-Position: refs/heads/master@{#313838}

[fgorski, 2015-01-28 23:28:24]

Nicolas, please take a look. As part of investigation of another issue today we
discovered that the user of StringToInt64 might be incorrect, when the
conversion fails: it will change time_internal to a value different than 0.

[Nicolas Zea, 2015-01-29 01:06:05]

should we have a unit test for this?

[miu, 2015-01-29 02:56:16]

lgtm % concerns (I don't know this code well enough to take a stance on these):

https://codereview.chromium.org/884783003/diff/1/google_apis/gcm/engine/gcm_s...
File google_apis/gcm/engine/gcm_store_impl.cc (right):

https://codereview.chromium.org/884783003/diff/1/google_apis/gcm/engine/gcm_s...
google_apis/gcm/engine/gcm_store_impl.cc:778: time_internal = 0LL;
Should this method return false here instead?

https://codereview.chromium.org/884783003/diff/1/google_apis/gcm/engine/gcm_s...
google_apis/gcm/engine/gcm_store_impl.cc:860: time_internal = 0LL;
ditto: Should this method return false here instead?

[fgorski, 2015-01-29 22:48:45]

Updated. PTAL

https://codereview.chromium.org/884783003/diff/1/google_apis/gcm/engine/gcm_s...
File google_apis/gcm/engine/gcm_store_impl.cc (right):

https://codereview.chromium.org/884783003/diff/1/google_apis/gcm/engine/gcm_s...
google_apis/gcm/engine/gcm_store_impl.cc:778: time_internal = 0LL;
On 2015/01/29 02:56:15, miu wrote:
> Should this method return false here instead?

This is not as severe as other problems we might be hitting in this file. I'll
work out the recovery strategy for this file being corrupted, but there is no
need to fail here.

https://codereview.chromium.org/884783003/diff/1/google_apis/gcm/engine/gcm_s...
google_apis/gcm/engine/gcm_store_impl.cc:860: time_internal = 0LL;
On 2015/01/29 02:56:16, miu wrote:
> ditto: Should this method return false here instead?

Same here.

[Nicolas Zea, 2015-01-29 23:11:39]

LGTM

[fgorski, 2015-01-30 00:28:10]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2015-01-30 00:29:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/884783003/20001

[commit-bot: I haz the power, 2015-01-30 00:33:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-30 00:35:47]

Patchset 2 (id:??) landed as
https://crrev.com/37fbf9cda8bcc2b85e537d2d2e4fc0db4749706f
Cr-Commit-Position: refs/heads/master@{#313838}