Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 884713004: Add UMA to histograms.xml for PLT.*_HTTPS_DataReductionProxy (Closed)

Created:
5 years, 10 months ago by jeremyim
Modified:
5 years, 10 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, bengr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA to histograms.xml for PLT.*_HTTPS_DataReductionProxy BUG=374264 Committed: https://crrev.com/e5ec4c67544f3f19bd488140f948bca6e1884e6d Cr-Commit-Position: refs/heads/master@{#313637}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
jeremyim
asvitkine PTAL! =)
5 years, 10 months ago (2015-01-28 21:40:38 UTC) #2
Alexei Svitkine (slow)
Could you use the histogram_suffixes feature in the xml instead?
5 years, 10 months ago (2015-01-28 22:07:20 UTC) #3
jeremyim
That makes the code much simpler! Thanks!
5 years, 10 months ago (2015-01-28 22:17:20 UTC) #4
Alexei Svitkine (slow)
https://codereview.chromium.org/884713004/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/884713004/diff/20001/tools/metrics/histograms/histograms.xml#newcode59508 tools/metrics/histograms/histograms.xml:59508: + <suffix name="HTTPS_DataReductionProxy" Could you add this suffix to ...
5 years, 10 months ago (2015-01-28 22:20:08 UTC) #5
jeremyim
On 2015/01/28 22:20:08, Alexei Svitkine wrote: > https://codereview.chromium.org/884713004/diff/20001/tools/metrics/histograms/histograms.xml > File tools/metrics/histograms/histograms.xml (right): > > https://codereview.chromium.org/884713004/diff/20001/tools/metrics/histograms/histograms.xml#newcode59508 ...
5 years, 10 months ago (2015-01-28 22:22:27 UTC) #6
Alexei Svitkine (slow)
lgtm
5 years, 10 months ago (2015-01-28 22:31:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884713004/40001
5 years, 10 months ago (2015-01-28 22:33:31 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-29 00:28:32 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 00:29:35 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e5ec4c67544f3f19bd488140f948bca6e1884e6d
Cr-Commit-Position: refs/heads/master@{#313637}

Powered by Google App Engine
This is Rietveld 408576698