remoting/tools/javascript_key_tester/chord_tracker.js - Issue 884703006: Handling PNaCl KeyboardInputEvent(s) in the key tester app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/tools/javascript_key_tester/chord_tracker.js

Issue 884703006: Handling PNaCl KeyboardInputEvent(s) in the key tester app. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « remoting/tools/javascript_key_tester/README ('k') | remoting/tools/javascript_key_tester/main.css » ('j') | remoting/tools/javascript_key_tester/pnacl/remoting_key_tester.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/tools/javascript_key_tester/chord_tracker.js

diff --git a/remoting/tools/javascript_key_tester/chord_tracker.js b/remoting/tools/javascript_key_tester/chord_tracker.js

index ee2a32771873f0c235ca079fe6a9c95a9bdb8e19..a701b93981356dd10fe54edc7e430299ac0dbc9f 100644

--- a/remoting/tools/javascript_key_tester/chord_tracker.js

+++ b/remoting/tools/javascript_key_tester/chord_tracker.js

@@ -51,7 +51,7 @@ ChordTracker.prototype.begin_ = function() {

}

this.currentDiv_ = document.createElement('div');

this.currentDiv_.classList.add('chord-div');

- this.parentDiv_.appendChild(this.currentDiv_);

+ this.parentDiv_.insertBefore(this.currentDiv_, this.parentDiv_.firstChild);

Łukasz Anforowicz 2015/01/28 22:15:35 By prepending, rather than appending, one doesn't

Jamie 2015/01/28 22:31:27 Acknowledged.

};

/**