Issue 884683002: Revert of PlzNavigate: Add a browser test for basic navigations

Issue 884683002: Revert of PlzNavigate: Add a browser test for basic navigations (Closed)

Created:
5 years, 10 months ago by dconnelly

Modified:
5 years, 10 months ago

Reviewers:
clamy, carlosk, nasko

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of PlzNavigate: Add a browser test for basic navigations (patchset #6 id:100001 of https://codereview.chromium.org/715203004/) Reason for revert: Broke the build: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/7409 http://build.chromium.org/p/chromium.webkit/builders/Linux%20GN/builds/18976 http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/73255 Original issue's description: > PlzNavigate: Add a browser test for basic navigations > > This CL adds a browsertest that checks that basic browser initiated navigations > work with browser side navigations enabled. > > BUG=376014, 376006, 376091 > > Committed: https://crrev.com/cd857adbb07fb2e889fa24282648e1f64ede2c95 > Cr-Commit-Position: refs/heads/master@{#313480} TBR=carlosk@chromium.org,nasko@chromium.org,clamy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=376014, 376006, 376091 Committed: https://crrev.com/34c26cbab561ca23cddde3b7dc197133d0d2bbd0 Cr-Commit-Position: refs/heads/master@{#313481}

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+122 lines, -348 lines)			Patch
D	content/browser/browser_side_navigation_browsertest.cc	View	1 chunk	+0 lines, -162 lines	0 comments	Download
M	content/browser/site_per_process_browsertest.cc	View	37 chunks	+122 lines, -77 lines	0 comments	Download
M	content/content_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/test/test_navigation_observer.h	View	4 chunks	+0 lines, -24 lines	0 comments	Download
M	content/public/test/test_navigation_observer.cc	View	2 chunks	+0 lines, -50 lines	0 comments	Download
M	content/renderer/render_frame_impl.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	content/test/data/simple_links.html	View	1 chunk	+0 lines, -33 lines	0 comments	Download

Total messages: 4 (0 generated)

dconnelly

Created Revert of PlzNavigate: Add a browser test for basic navigations

5 years, 10 months ago (2015-01-28 11:47:26 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884683002/1

5 years, 10 months ago (2015-01-28 11:48:09 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-01-28 11:50:08 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/34c26cbab561ca23cddde3b7dc197133d0d2bbd0
Cr-Commit-Position: refs/heads/master@{#313481}