Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 884663002: Should use sofile instead of soname. (Closed)

Created:
5 years, 10 months ago by Yoshisato Yanagisawa
Modified:
5 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Should use sofile instead of soname. If soname is used here, nm cannot find the file if non-default toolchain is used. Committed: https://crrev.com/a2ed43445333a1f317e54c16ffda5b69e0786e39 Cr-Commit-Position: refs/heads/master@{#313639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/toolchain/gcc_toolchain.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Yoshisato Yanagisawa
Hi, During the use of GN for our purpose, I found issue on gcc_toolchain.gni. nm ...
5 years, 10 months ago (2015-01-28 09:16:38 UTC) #2
scottmg
lgtm
5 years, 10 months ago (2015-01-28 17:33:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884663002/1
5 years, 10 months ago (2015-01-29 00:32:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 00:35:11 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 00:35:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2ed43445333a1f317e54c16ffda5b69e0786e39
Cr-Commit-Position: refs/heads/master@{#313639}

Powered by Google App Engine
This is Rietveld 408576698