gfx::ShadowValue: offset is a Vector2d, not Point.

ui/gfx/shadow_value_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gfx/geometry/insets.h"
+#include "ui/gfx/geometry/vector2d.h"
 #include "ui/gfx/shadow_value.h"
 
 namespace gfx {
 
 TEST(ShadowValueTest, GetMargin) {
   const struct TestCase {
     Insets expected_margin;
     size_t shadow_count;
     ShadowValue shadows[2];
   } kTestCases[] = {
-    {
-      Insets(), 0, {},
-    },
-    {
-      Insets(-2, -2, -2, -2),
-      1,
-      { ShadowValue(gfx::Point(0, 0), 4, 0), },
-    },
-    {
-      Insets(0, -1, -4, -3),
-      1,
-      { ShadowValue(gfx::Point(1, 2), 4, 0), },
-    },
-    {
-      Insets(-4, -3, 0, -1),
-      1,
-      { ShadowValue(gfx::Point(-1, -2), 4, 0), },
-    },
-    {
-      Insets(0, -1, -5, -4),
-      2,
       {
-        ShadowValue(gfx::Point(1, 2), 4, 0),
-        ShadowValue(gfx::Point(2, 3), 4, 0),
+       Insets(), 0, {},

[danakj, 2015/02/24 17:26:55]

This indenting looks weird, did git cl format do this?

[Matt Giuca, 2015/02/24 23:04:21]

It did. I don't know why it likes 1-space indents in this particular place.

Do you want me to revert the formatting (I don't think there is a presubmit
check for clang-format in this directory)? Or just accept what it's doing here?

[danakj, 2015/02/24 23:07:17]

Accept it and file a bug please.

[Matt Giuca, 2015/02/25 04:34:41]

Done. (b/19503635)

I'm not sure why you want me to accept it, given that if the bug is fixed, this
file will be incorrectly formatted. But unless you change your mind, I'll do
that.

[danakj, 2015/02/25 19:04:24]

Well, because otherwise other people who touch the file will have to go undo
clangformat too.

Maybe this file doesn't have enough traffic to warrent that though. I'm fine
with making it right and ignoring clang-format here too.

[Matt Giuca, 2015/02/26 03:19:19]

OK done. (I think it's especially good to not be doing big formatting changes on
an already-widespread CL).

       },
-    },
-    {
-      Insets(-4, -3, -5, -4),
-      2,
       {
-        ShadowValue(gfx::Point(-1, -2), 4, 0),
-        ShadowValue(gfx::Point(2, 3), 4, 0),
+       Insets(-2, -2, -2, -2),
+       1,
+       {
+        ShadowValue(gfx::Vector2d(0, 0), 4, 0),
+       },
       },
-    },
+      {
+       Insets(0, -1, -4, -3),
+       1,
+       {
+        ShadowValue(gfx::Vector2d(1, 2), 4, 0),
+       },
+      },
+      {
+       Insets(-4, -3, 0, -1),
+       1,
+       {
+        ShadowValue(gfx::Vector2d(-1, -2), 4, 0),
+       },
+      },
+      {
+       Insets(0, -1, -5, -4),
+       2,
+       {
+        ShadowValue(gfx::Vector2d(1, 2), 4, 0),
+        ShadowValue(gfx::Vector2d(2, 3), 4, 0),
+       },
+      },
+      {
+       Insets(-4, -3, -5, -4),
+       2,
+       {
+        ShadowValue(gfx::Vector2d(-1, -2), 4, 0),
+        ShadowValue(gfx::Vector2d(2, 3), 4, 0),
+       },
+      },
   };
 
   for (size_t i = 0; i < arraysize(kTestCases); ++i) {
     Insets margin = ShadowValue::GetMargin(
         ShadowValues(kTestCases[i].shadows,
                      kTestCases[i].shadows + kTestCases[i].shadow_count));
 
     EXPECT_EQ(kTestCases[i].expected_margin, margin) << " i=" << i;
   }
 }
 
 }  // namespace gfx