Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issue 884653002: Update visual style of directory tree. (Closed)

Created:
5 years, 11 months ago by fukino
Modified:
5 years, 11 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update visual style of directory tree. Main changes are: - Layout change. - Selected tree item's color is not inverted now. - Use core-icon's preset icons for for subfolders. - Add touch feedback. BUG=402344 TEST=run browser_tests Committed: https://crrev.com/9a8600ac6a908f33cc4d0e5dd2cf6885fc05c121 Cr-Commit-Position: refs/heads/master@{#313474}

Patch Set 1 #

Patch Set 2 : Remove unused tree.css.js. #

Total comments: 4

Patch Set 3 : Remove eject_white.png #

Messages

Total messages: 9 (2 generated)
fukino
PTAL. Thanks!
5 years, 11 months ago (2015-01-28 09:17:39 UTC) #2
hirono
lgtm with nits! Thanks! https://codereview.chromium.org/884653002/diff/20001/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (left): https://codereview.chromium.org/884653002/diff/20001/ui/file_manager/file_manager/foreground/css/file_manager.css#oldcode276 ui/file_manager/file_manager/foreground/css/file_manager.css:276: url(../images/files/ui/eject_white.png) 1x, Can we remove ...
5 years, 11 months ago (2015-01-28 09:21:15 UTC) #3
fukino
Thank you for quick review! https://codereview.chromium.org/884653002/diff/20001/ui/file_manager/file_manager/foreground/css/file_types.css File ui/file_manager/file_manager/foreground/css/file_types.css (right): https://codereview.chromium.org/884653002/diff/20001/ui/file_manager/file_manager/foreground/css/file_types.css#newcode347 ui/file_manager/file_manager/foreground/css/file_types.css:347: background-image: -webkit-image-set( On 2015/01/28 ...
5 years, 11 months ago (2015-01-28 09:32:17 UTC) #4
fukino
https://codereview.chromium.org/884653002/diff/20001/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (left): https://codereview.chromium.org/884653002/diff/20001/ui/file_manager/file_manager/foreground/css/file_manager.css#oldcode276 ui/file_manager/file_manager/foreground/css/file_manager.css:276: url(../images/files/ui/eject_white.png) 1x, On 2015/01/28 09:21:14, hirono wrote: > Can ...
5 years, 11 months ago (2015-01-28 09:32:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884653002/40001
5 years, 11 months ago (2015-01-28 09:33:55 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-28 10:19:50 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-28 10:20:48 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9a8600ac6a908f33cc4d0e5dd2cf6885fc05c121
Cr-Commit-Position: refs/heads/master@{#313474}

Powered by Google App Engine
This is Rietveld 408576698