Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 884643003: Revert of Reenable oobe spoken feedback test. (Closed)

Created:
5 years, 10 months ago by dconnelly
Modified:
5 years, 10 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reenable oobe spoken feedback test. (patchset #4 id:60001 of https://codereview.chromium.org/866713002/) Reason for revert: Still failing :( http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/6244 http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/6247 Original issue's description: > Reenable oobe spoken feedback test. > > The test was disabled because it was flaky. This CL tries to address that > and reenables the test. > > BUG=346797 > R=dtseng@chromium.org > > Committed: https://crrev.com/e03f042d1c76262248e42334b1d0326b0e4319e7 > Cr-Commit-Position: refs/heads/master@{#313467} TBR=dtseng@chromium.org,dmazzoni@chromium.org,plundblad@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=346797 Committed: https://crrev.com/d65ea3868f1f9457061dfee03feac7495298b1cd Cr-Commit-Position: refs/heads/master@{#313498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -55 lines) Patch
M chrome/browser/chromeos/accessibility/speech_monitor.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 6 chunks +34 lines, -54 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dconnelly
Created Revert of Reenable oobe spoken feedback test.
5 years, 10 months ago (2015-01-28 13:28:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884643003/1
5 years, 10 months ago (2015-01-28 13:29:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 13:29:53 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 13:31:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d65ea3868f1f9457061dfee03feac7495298b1cd
Cr-Commit-Position: refs/heads/master@{#313498}

Powered by Google App Engine
This is Rietveld 408576698