Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 884623003: Suppress native app install banner if the site has a manifest. (Closed)

Created:
5 years, 10 months ago by benwells
Modified:
5 years, 10 months ago
Reviewers:
Ted C, gone
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress native app install banner if the site has a manifest. This is the first step on support 'add to homescreen' banners for sites that have manifests. BUG=452825 Committed: https://crrev.com/5cf2cf1c9c1e5a48d0d2fe5e4e856160390384aa Cr-Commit-Position: refs/heads/master@{#313612}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -110 lines) Patch
M chrome/browser/android/banners/app_banner_manager.h View 3 chunks +20 lines, -6 lines 0 comments Download
M chrome/browser/android/banners/app_banner_manager.cc View 5 chunks +57 lines, -4 lines 3 comments Download
D chrome/browser/android/meta_tag_observer.h View 1 chunk +0 lines, -44 lines 1 comment Download
D chrome/browser/android/meta_tag_observer.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
benwells
Dan - I started looking at the history stuff and realised it will be pretty ...
5 years, 10 months ago (2015-01-28 09:24:23 UTC) #2
gone
lgtm https://chromiumcodereview.appspot.com/884623003/diff/1/chrome/browser/android/banners/app_banner_manager.cc File chrome/browser/android/banners/app_banner_manager.cc (right): https://chromiumcodereview.appspot.com/884623003/diff/1/chrome/browser/android/banners/app_banner_manager.cc#newcode88 chrome/browser/android/banners/app_banner_manager.cc:88: // lifetime of this object extends beyond the ...
5 years, 10 months ago (2015-01-28 18:44:13 UTC) #3
gone
+Ted for OWNERS
5 years, 10 months ago (2015-01-28 18:44:46 UTC) #5
Ted C
lgtm
5 years, 10 months ago (2015-01-28 18:50:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884623003/1
5 years, 10 months ago (2015-01-28 23:19:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 23:23:50 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 23:25:02 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5cf2cf1c9c1e5a48d0d2fe5e4e856160390384aa
Cr-Commit-Position: refs/heads/master@{#313612}

Powered by Google App Engine
This is Rietveld 408576698