Tweaks for reporting duplicates, issue 519.

Tweaks for reporting duplicates, issue 519.
http://code.google.com/p/dart/issues/detail?id=519

New tests, plus inlining existing *.dart files into tests with strict checks.


R=zundel@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=2343

[zundel, 2011-12-07 19:12:45]

http://codereview.chromium.org/8846002/diff/1/compiler/javatests/com/google/d...
File
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
(right):

http://codereview.chromium.org/8846002/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java:194:
errEx(ResolverErrorCode.DUPLICATE_FIELD, 2, 5, 3),
I know this is the way its written, but does it make sense to warn about each
declaration twice?  The first error messages from MemberBuilder already flag the
2 members as duplicate.

http://codereview.chromium.org/8846002/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java:401:
errEx(ResolverErrorCode.DUPLICATE_FIELD, 4, 7, 3));
Huh, I wonder why it didn't spit out a DUPLICATE_MEMBER here for set foo(x)? It
did for toplevel members.

[scheglov, 2011-12-12 15:50:12]

http://codereview.chromium.org/8846002/diff/1/compiler/javatests/com/google/d...
File
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
(right):

http://codereview.chromium.org/8846002/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java:194:
errEx(ResolverErrorCode.DUPLICATE_FIELD, 2, 5, 3),
On 2011/12/07 19:12:51, zundel wrote:
> I know this is the way its written, but does it make sense to warn about each
> declaration twice?  The first error messages from MemberBuilder already flag
the
> 2 members as duplicate.

OK, no more FIELD.

http://codereview.chromium.org/8846002/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java:401:
errEx(ResolverErrorCode.DUPLICATE_FIELD, 4, 7, 3));
On 2011/12/07 19:12:51, zundel wrote:
> Huh, I wonder why it didn't spit out a DUPLICATE_MEMBER here for set foo(x)?
It
> did for toplevel members.

Done.

[zundel, 2011-12-12 16:02:59]

lgtm

http://codereview.chromium.org/8846002/diff/4001/compiler/javatests/com/googl...
File
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
(right):

http://codereview.chromium.org/8846002/diff/4001/compiler/javatests/com/googl...
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java:526:
* Setter shadows another setter.
Setter --> Getter   and setter --> getter