tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py - Issue 884573004: Check the context type in StopChromeTracing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

Issue 884573004: Check the context type in StopChromeTracing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: disable test Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

index 4dc7f755b5684ff3e83df506e1f0eef14f454bb2..347bcb6f73ff2b3cf4df2c1b00dfab591abf333c 100644

--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

@@ -134,6 +134,8 @@ class DevToolsClientBackend(object):

def StopChromeTracing(self, trace_data_builder, timeout=30):

context_map = self.GetUpdatedInspectableContexts()

for context in context_map.contexts:

+ if context['type'] not in ['iframe', 'page', 'webview']:

+ continue

context_id = context['id']

backend = context_map.GetInspectorBackend(context_id)

success = backend.EvaluateJavaScript(

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/platform/tracing_controller_unittest.py » ('j') | no next file with comments »