Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 884503002: store InstructionOperands directly in Instruction (Closed)

Created:
5 years, 10 months ago by dcarney
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

store InstructionOperands directly in Instruction BUG= Committed: https://crrev.com/f5ca41450a65a18019a1f843810ee768ed36a030 Cr-Commit-Position: refs/heads/master@{#26329}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -42 lines) Patch
M src/compiler/instruction.h View 1 2 3 4 6 chunks +32 lines, -39 lines 0 comments Download
M src/compiler/instruction.cc View 1 1 chunk +41 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Benedikt Meurer
lgtm
5 years, 10 months ago (2015-01-29 08:55:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884503002/100001
5 years, 10 months ago (2015-01-29 15:30:38 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 10 months ago (2015-01-29 16:00:15 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 16:00:30 UTC) #7
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f5ca41450a65a18019a1f843810ee768ed36a030
Cr-Commit-Position: refs/heads/master@{#26329}

Powered by Google App Engine
This is Rietveld 408576698