Function type checking: Part Deux

compiler/javatests/com/google/dart/compiler/backend/js/ClosureJsCodingConventionTest.java

Index: compiler/javatests/com/google/dart/compiler/backend/js/ClosureJsCodingConventionTest.java
diff --git a/compiler/javatests/com/google/dart/compiler/backend/js/ClosureJsCodingConventionTest.java b/compiler/javatests/com/google/dart/compiler/backend/js/ClosureJsCodingConventionTest.java
deleted file mode 100644
index 30dd1f469b23682341f763948180ffcb19f6a443..0000000000000000000000000000000000000000
--- a/compiler/javatests/com/google/dart/compiler/backend/js/ClosureJsCodingConventionTest.java
+++ /dev/null
@@ -1,30 +0,0 @@
-// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-package com.google.dart.compiler.backend.js;
-
-import com.google.javascript.jscomp.CodingConvention.Bind;
-import com.google.javascript.rhino.Node;
-import com.google.javascript.rhino.Token;
-
-import junit.framework.TestCase;
-
-/**
- * @author johnlenz@google.com (John Lenz)
- */
-public class ClosureJsCodingConventionTest extends TestCase {

[mmendez, 2011/12/07 20:03:00]

Nit: it might be worth while to leave this in but simply update it to cover the
behaviors that we care about.

[codefu, 2011/12/07 21:44:54]

This test was failing bellow after we removed the overridden
describeFunctionBind() from ClosureJsCodeingConvention()

-   public void testBind() {
-     ClosureJsCodingConvention convention = new ClosureJsCodingConvention();
-
-     // don't recognize a non-bind call.
-     Node expr = new Node(Token.CALL, Node.newString(Token.NAME, "foo"));
-     assertNull(convention.describeFunctionBind(expr));
-
-     // don't recognize a bind call.
-     expr = new Node(Token.CALL,
-       Node.newString(Token.NAME, "$bind"), new Node(Token.THIS));
-     Bind bind = convention.describeFunctionBind(expr);
-     assertNotNull(bind);
-   }
-}