Function type checking: Part Deux

Function type checking: Part Deux

This replaced the following CL that was falling behind head.
http://codereview.chromium.org/8566022/

Summary:
Add support for function runtime type checking and typedefs; re-worked to
support tree-shaking at head.  Static, instance, top level, and hoisted
methods have RTT lookup methods to identify their types.  Respective
getters() and binds() have been updated or added to link the lookup methods 
to bounded methods. Static method getters were added as well to perform this
linking for non-bound situations.

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=2263

[codefu, 2011-12-07 16:32:04]

PTAL

[mmendez, 2011-12-07 20:03:00]

LGTM

Feel free to address the comments in a follow on patch.  As an FYI, this does
increase the tree shaken incremental outpf JS size of total by about 100kb due
to the additional function type information.  The reason that it can't be shaken
out in the incremental mode is due to the current name mangling.  For example,
the isUtc property on one class would mangle to the same name as an isUtc method
in another class, isUtc$getter.  Something to consider for a subsequent change.

http://codereview.chromium.org/8845002/diff/1/compiler/java/com/google/dart/c...
File
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
(right):

http://codereview.chromium.org/8845002/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:609:
String mangledRttMethodName = mangledMethodName + "_$lookupRTT";
Nit: you could add this logic to the mangler instance which should make changing
the mangling simpler.

http://codereview.chromium.org/8845002/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:643:
asg = func;
Missing call to setSourceRef?

http://codereview.chromium.org/8845002/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:2994:
hoistedRttName = hoistedName.toString() + "_$lookupRTT";
Nit: See comment above about name mangling.

http://codereview.chromium.org/8845002/diff/1/compiler/javatests/com/google/d...
File
compiler/javatests/com/google/dart/compiler/backend/js/ClosureJsCodingConventionTest.java
(left):

http://codereview.chromium.org/8845002/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/backend/js/ClosureJsCodingConventionTest.java:16:
public class ClosureJsCodingConventionTest extends TestCase {
Nit: it might be worth while to leave this in but simply update it to cover the
behaviors that we care about.

http://codereview.chromium.org/8845002/diff/1/compiler/lib/implementation/cor...
File compiler/lib/implementation/core.js (right):

http://codereview.chromium.org/8845002/diff/1/compiler/lib/implementation/cor...
compiler/lib/implementation/core.js:17: if (fRtt) {
Nit: this if (fRtt) block could be moved to a common function.

http://codereview.chromium.org/8845002/diff/1/compiler/lib/implementation/rtt.js
File compiler/lib/implementation/rtt.js (right):

http://codereview.chromium.org/8845002/diff/1/compiler/lib/implementation/rtt...
compiler/lib/implementation/rtt.js:317: function getDynamic() {
Do you still need this function to pass optimized tests?

http://codereview.chromium.org/8845002/diff/1/tests/language/language.status
File tests/language/language.status (right):

http://codereview.chromium.org/8845002/diff/1/tests/language/language.status#...
tests/language/language.status:88: BlackListedTest/13: Fail # Bug 5469684
Nit: Will these now failing tests pass with your subsequent patch?

[codefu, 2011-12-07 21:44:54]

Cleaned up nits; running tests now.

http://codereview.chromium.org/8845002/diff/1/compiler/java/com/google/dart/c...
File
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
(right):

http://codereview.chromium.org/8845002/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:609:
String mangledRttMethodName = mangledMethodName + "_$lookupRTT";
On 2011/12/07 20:03:00, mmendez wrote:
> Nit: you could add this logic to the mangler instance which should make
changing
> the mangling simpler.

Done.

http://codereview.chromium.org/8845002/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:642:
func.setName(globalScope.declareName(getterJsNameRef.toString()));
Could this just be func.setName(getterJsNameRef.getName())?

http://codereview.chromium.org/8845002/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:643:
asg = func;
On 2011/12/07 20:03:00, mmendez wrote:
> Missing call to setSourceRef?

Top levels didn't have a $getter before this change. I could move the
asg.setSourceRef() to below the if/else.

http://codereview.chromium.org/8845002/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:2994:
hoistedRttName = hoistedName.toString() + "_$lookupRTT";
On 2011/12/07 20:03:00, mmendez wrote:
> Nit: See comment above about name mangling.

Done and updated in all the other locations.

http://codereview.chromium.org/8845002/diff/1/compiler/javatests/com/google/d...
File
compiler/javatests/com/google/dart/compiler/backend/js/ClosureJsCodingConventionTest.java
(left):

http://codereview.chromium.org/8845002/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/backend/js/ClosureJsCodingConventionTest.java:16:
public class ClosureJsCodingConventionTest extends TestCase {
On 2011/12/07 20:03:00, mmendez wrote:
> Nit: it might be worth while to leave this in but simply update it to cover
the
> behaviors that we care about.

This test was failing bellow after we removed the overridden
describeFunctionBind() from ClosureJsCodeingConvention()

http://codereview.chromium.org/8845002/diff/1/compiler/lib/implementation/cor...
File compiler/lib/implementation/core.js (right):

http://codereview.chromium.org/8845002/diff/1/compiler/lib/implementation/cor...
compiler/lib/implementation/core.js:17: if (fRtt) {
On 2011/12/07 20:03:00, mmendez wrote:
> Nit: this if (fRtt) block could be moved to a common function.

Done.

http://codereview.chromium.org/8845002/diff/1/compiler/lib/implementation/rtt.js
File compiler/lib/implementation/rtt.js (right):

http://codereview.chromium.org/8845002/diff/1/compiler/lib/implementation/rtt...
compiler/lib/implementation/rtt.js:317: function getDynamic() {
On 2011/12/07 20:03:00, mmendez wrote:
> Do you still need this function to pass optimized tests?

Not anymore. John Lenz solved this by pointing out I needed to use
newQualifiedNameRef() in RuntimeTypeInjector.

http://codereview.chromium.org/8845002/diff/1/tests/language/language.status
File tests/language/language.status (right):

http://codereview.chromium.org/8845002/diff/1/tests/language/language.status#...
tests/language/language.status:88: BlackListedTest/13: Fail # Bug 5469684
On 2011/12/07 20:03:00, mmendez wrote:
> Nit: Will these now failing tests pass with your subsequent patch?

No. The blacklisted tests should all report compile time errors as it tests
implementing or extending certain internal classes/interfaces