Image Capture PPAPI: remove unused APIs

Image Capture PPAPI: remove unused APIs

1. Remove ppb_image_capture_config_private.
2. Remove PPB_ImageCapture_Private.{Set|Get}Config
3. Remove PPB_ImageCapture_Private.CaptureStillImage

BUG=387547
TEST=None

Committed: https://crrev.com/e04cb0a6d89e5757d05e663a264e4059c0197e83
Cr-Commit-Position: refs/heads/master@{#314834}

[Justin Chuang, 2015-02-03 14:44:27]

jchuang@chromium.org changed reviewers:
+ dmichael@chromium.org, wuchengli@chromium.org

[dmichael (off chromium), 2015-02-03 19:38:23]

https://codereview.chromium.org/884483007/diff/1/ppapi/api/private/ppb_image_...
File ppapi/api/private/ppb_image_capture_private.idl (right):

https://codereview.chromium.org/884483007/diff/1/ppapi/api/private/ppb_image_...
ppapi/api/private/ppb_image_capture_private.idl:18: * To capture a still image
with this class, use the following steps.
We can't capture an image with this API, so that probably should be updated.

https://codereview.chromium.org/884483007/diff/1/ppapi/api/private/ppb_image_...
ppapi/api/private/ppb_image_capture_private.idl:25: interface
PPB_ImageCapture_Private {
Should it be renamed to something like:
PPB_CameraCapabilities_Private
or
PPB_ImageCaptureDevice_Private
?

[Justin Chuang, 2015-02-04 09:46:49]

https://codereview.chromium.org/884483007/diff/1/ppapi/api/private/ppb_image_...
File ppapi/api/private/ppb_image_capture_private.idl (right):

https://codereview.chromium.org/884483007/diff/1/ppapi/api/private/ppb_image_...
ppapi/api/private/ppb_image_capture_private.idl:18: * To capture a still image
with this class, use the following steps.
On 2015/02/03 19:38:23, dmichael wrote:
> We can't capture an image with this API, so that probably should be updated.

Done.

https://codereview.chromium.org/884483007/diff/1/ppapi/api/private/ppb_image_...
ppapi/api/private/ppb_image_capture_private.idl:25: interface
PPB_ImageCapture_Private {
Yeah... the current PPAPI name looks odd after removing unused API.

Two choices:
1. Rename PPB_ImageCapture_Private to PPB_CameraDevice_Private 
(not PPB_ImageCaptureDevice_Private, because it is not only about "Image
Capture". It is enumerating "video capture" formats.)

2. Merge PPB_ImageCapture_Private into PPB_CameraCapabilities_Private. Only one
PPAPI (PPB_CameraCapabilities_Private) is left.

I strongly prefer Choice 1 because it's more flexible to support more camera
functionalities like CaptureStillImage and Set/GetCaptureConfig when we have
more capable HW & OS support. 
Choice 2 is okay for the current purpose, but it's not correct API design to
support more camera features in the long run. 

Also, shall I do it in a separate CL because it needs renaming of multiple
files?

[dmichael (off chromium), 2015-02-04 17:35:39]

lgtm, thanks!

https://codereview.chromium.org/884483007/diff/1/ppapi/api/private/ppb_image_...
File ppapi/api/private/ppb_image_capture_private.idl (right):

https://codereview.chromium.org/884483007/diff/1/ppapi/api/private/ppb_image_...
ppapi/api/private/ppb_image_capture_private.idl:25: interface
PPB_ImageCapture_Private {
On 2015/02/04 09:46:49, Justin Chuang wrote:
> Yeah... the current PPAPI name looks odd after removing unused API.
> 
> Two choices:
> 1. Rename PPB_ImageCapture_Private to PPB_CameraDevice_Private 
> (not PPB_ImageCaptureDevice_Private, because it is not only about "Image
> Capture". It is enumerating "video capture" formats.)
> 
> 2. Merge PPB_ImageCapture_Private into PPB_CameraCapabilities_Private. Only
one
> PPAPI (PPB_CameraCapabilities_Private) is left.
> 
> I strongly prefer Choice 1 because it's more flexible to support more camera
> functionalities like CaptureStillImage and Set/GetCaptureConfig when we have
> more capable HW & OS support. 
> Choice 2 is okay for the current purpose, but it's not correct API design to
> support more camera features in the long run. 
> 
> Also, shall I do it in a separate CL because it needs renaming of multiple
> files?
SGTM, let's do option 1.

[wuchengli, 2015-02-05 03:08:04]

lgtm

[Justin Chuang, 2015-02-05 15:00:17]

New patchsets have been uploaded after l-g-t-m from
dmichael@chromium.org,wuchengli@chromium.org

[Justin Chuang, 2015-02-05 17:05:33]

The CQ bit was checked by jchuang@chromium.org

[commit-bot: I haz the power, 2015-02-05 17:05:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/884483007/60001

[commit-bot: I haz the power, 2015-02-05 18:01:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-05 18:02:30]

Patchset 4 (id:??) landed as
https://crrev.com/e04cb0a6d89e5757d05e663a264e4059c0197e83
Cr-Commit-Position: refs/heads/master@{#314834}