Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 884483006: Allows top controls to be hidden by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix for downstream Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
index 13ffa6f1e5e603cb227978f13f56d5bf6a5a2bb4..1e69e71c12fc25fc8077452ca4373c51b314d0fd 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
@@ -2264,6 +2264,14 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
}
/**
+ * @return Whether showing top controls is enabled or not.
+ */
+ public boolean isShowingTopControlsEnabled() {
+ if (mFullscreenManager == null) return true;
+ return !mFullscreenManager.getPersistentFullscreenMode();
+ }
+
+ /**
* @return The current visibility constraints for the display of top controls.
* {@link TopControlsState} defines the valid return options.
*/
@@ -2271,7 +2279,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
if (mFullscreenManager == null) return TopControlsState.SHOWN;
boolean enableHidingTopControls = isHidingTopControlsEnabled();
- boolean enableShowingTopControls = !mFullscreenManager.getPersistentFullscreenMode();
+ boolean enableShowingTopControls = isShowingTopControlsEnabled();
int constraints = TopControlsState.BOTH;
if (!enableShowingTopControls) {
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698