Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 884483005: Revert of Add build targets for Opus tests. (Closed)

Created:
5 years, 10 months ago by henrika (OOO until Aug 14)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add build targets for Opus tests. (patchset #2 id:20001 of https://codereview.chromium.org/894473002/) Reason for revert: This CL breaks WebRTC in Chrome and must be reverted. Contact tlegrand@ for more details. Original issue's description: > Add build targets for Opus tests. > > test_opus_api, test_opus_encode, test_opus_decode, and test_opus_padding > can be run directly, with no command-line options, and they print out > "OK" during the test and an overall status message such as > "All API tests passed." or "Tests completed successfully." at the end. > > The celt component has several unit tests. I didn't add build targets > for them because some of them don't print any output, so you'd need a > test harness script to examine their exit status. > > R=henrika@chromium.org,sergeyu@chromium.org > BUG=452984 > > Committed: https://crrev.com/8b76b75f78ffdb9760ee7eea4f149c5d2b64bc89 > Cr-Commit-Position: refs/heads/master@{#314235} TBR=sergeyu@chromium.org,brettw@chromium.org,wtc@chromium.org, tlegrand@chromium.org BUG=452984 Committed: https://crrev.com/870ebb78d22969468c150393e6946dab5fd95cb6 Cr-Commit-Position: refs/heads/master@{#314308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -179 lines) Patch
M third_party/opus/BUILD.gn View 4 chunks +32 lines, -98 lines 0 comments Download
M third_party/opus/opus.gyp View 3 chunks +42 lines, -81 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
henrika (OOO until Aug 14)
Created Revert of Add build targets for Opus tests.
5 years, 10 months ago (2015-02-03 09:34:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884483005/1
5 years, 10 months ago (2015-02-03 09:37:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 10:53:49 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 10:54:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/870ebb78d22969468c150393e6946dab5fd95cb6
Cr-Commit-Position: refs/heads/master@{#314308}

Powered by Google App Engine
This is Rietveld 408576698