Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Side by Side Diff: Source/core/rendering/RenderView.h

Issue 884483003: Rename/move counter rendering code to layout. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderObjectChildList.cpp ('k') | Source/core/rendering/RenderView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2006 Apple Computer, Inc. 3 * Copyright (C) 2006 Apple Computer, Inc.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 148
149 IntervalArena* intervalArena(); 149 IntervalArena* intervalArena();
150 150
151 void setRenderQuoteHead(RenderQuote* head) { m_renderQuoteHead = head; } 151 void setRenderQuoteHead(RenderQuote* head) { m_renderQuoteHead = head; }
152 RenderQuote* renderQuoteHead() const { return m_renderQuoteHead; } 152 RenderQuote* renderQuoteHead() const { return m_renderQuoteHead; }
153 153
154 // FIXME: This is a work around because the current implementation of counte rs 154 // FIXME: This is a work around because the current implementation of counte rs
155 // requires walking the entire tree repeatedly and most pages don't actually use either 155 // requires walking the entire tree repeatedly and most pages don't actually use either
156 // feature so we shouldn't take the performance hit when not needed. Long te rm we should 156 // feature so we shouldn't take the performance hit when not needed. Long te rm we should
157 // rewrite the counter and quotes code. 157 // rewrite the counter and quotes code.
158 void addRenderCounter() { m_renderCounterCount++; } 158 void addLayoutCounter() { m_layoutCounterCount++; }
159 void removeRenderCounter() { ASSERT(m_renderCounterCount > 0); m_renderCount erCount--; } 159 void removeLayoutCounter() { ASSERT(m_layoutCounterCount > 0); m_layoutCount erCount--; }
160 bool hasRenderCounters() { return m_renderCounterCount; } 160 bool hasLayoutCounters() { return m_layoutCounterCount; }
161 161
162 virtual bool backgroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect) const override; 162 virtual bool backgroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect) const override;
163 163
164 double layoutViewportWidth() const; 164 double layoutViewportWidth() const;
165 double layoutViewportHeight() const; 165 double layoutViewportHeight() const;
166 166
167 void pushLayoutState(LayoutState& layoutState) { m_layoutState = &layoutStat e; } 167 void pushLayoutState(LayoutState& layoutState) { m_layoutState = &layoutStat e; }
168 void popLayoutState() { ASSERT(m_layoutState); m_layoutState = m_layoutState ->next(); } 168 void popLayoutState() { ASSERT(m_layoutState); m_layoutState = m_layoutState ->next(); }
169 virtual void invalidateTreeIfNeeded(const PaintInvalidationState&) override final; 169 virtual void invalidateTreeIfNeeded(const PaintInvalidationState&) override final;
170 170
(...skipping 22 matching lines...) Expand all
193 int m_selectionStartPos; 193 int m_selectionStartPos;
194 int m_selectionEndPos; 194 int m_selectionEndPos;
195 195
196 LayoutUnit m_pageLogicalHeight; 196 LayoutUnit m_pageLogicalHeight;
197 bool m_pageLogicalHeightChanged; 197 bool m_pageLogicalHeightChanged;
198 LayoutState* m_layoutState; 198 LayoutState* m_layoutState;
199 OwnPtr<RenderLayerCompositor> m_compositor; 199 OwnPtr<RenderLayerCompositor> m_compositor;
200 RefPtr<IntervalArena> m_intervalArena; 200 RefPtr<IntervalArena> m_intervalArena;
201 201
202 RawPtrWillBeMember<RenderQuote> m_renderQuoteHead; 202 RawPtrWillBeMember<RenderQuote> m_renderQuoteHead;
203 unsigned m_renderCounterCount; 203 unsigned m_layoutCounterCount;
204 204
205 unsigned m_hitTestCount; 205 unsigned m_hitTestCount;
206 206
207 class PendingSelection final { 207 class PendingSelection final {
208 DISALLOW_ALLOCATION(); 208 DISALLOW_ALLOCATION();
209 public: 209 public:
210 PendingSelection(); 210 PendingSelection();
211 void setSelection(const FrameSelection&); 211 void setSelection(const FrameSelection&);
212 void clear(); 212 void clear();
213 213
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 m_paintInvalidationState->m_cachedOffsetsEnabled = true; 251 m_paintInvalidationState->m_cachedOffsetsEnabled = true;
252 } 252 }
253 private: 253 private:
254 const PaintInvalidationState* m_paintInvalidationState; 254 const PaintInvalidationState* m_paintInvalidationState;
255 bool m_didDisable; 255 bool m_didDisable;
256 }; 256 };
257 257
258 } // namespace blink 258 } // namespace blink
259 259
260 #endif // RenderView_h 260 #endif // RenderView_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderObjectChildList.cpp ('k') | Source/core/rendering/RenderView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698