Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 884473006: [Toolbar] Move the component toolbar actions test to be cross-platform. (Closed)

Created:
5 years, 10 months ago by Devlin
Modified:
5 years, 10 months ago
Reviewers:
Finnur, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Toolbar] Move the component toolbar actions test to be cross-platform. The mac toolbar redesign has been implemented to the point where this test can be cross-platform. Move it to be so. BUG=429810 BUG=422381 TBR=sky@chromium.org (moving a file) Committed: https://crrev.com/ea2c721a232799f8c6ea2bbef5a6f952b3684317 Cr-Commit-Position: refs/heads/master@{#313744}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -166 lines) Patch
A + chrome/browser/ui/toolbar/component_toolbar_actions_browsertest.cc View 5 chunks +30 lines, -15 lines 2 comments Download
D chrome/browser/ui/views/toolbar/component_toolbar_actions_browsertest.cc View 1 chunk +0 lines, -150 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Devlin
5 years, 10 months ago (2015-01-29 01:10:38 UTC) #2
Finnur
Neat. LGTM, one question. https://codereview.chromium.org/884473006/diff/1/chrome/browser/ui/toolbar/component_toolbar_actions_browsertest.cc File chrome/browser/ui/toolbar/component_toolbar_actions_browsertest.cc (right): https://codereview.chromium.org/884473006/diff/1/chrome/browser/ui/toolbar/component_toolbar_actions_browsertest.cc#newcode17 chrome/browser/ui/toolbar/component_toolbar_actions_browsertest.cc:17: #include "ui/gfx/image/image_skia.h" nit: Is this ...
5 years, 10 months ago (2015-01-29 09:42:54 UTC) #3
Devlin
https://codereview.chromium.org/884473006/diff/1/chrome/browser/ui/toolbar/component_toolbar_actions_browsertest.cc File chrome/browser/ui/toolbar/component_toolbar_actions_browsertest.cc (right): https://codereview.chromium.org/884473006/diff/1/chrome/browser/ui/toolbar/component_toolbar_actions_browsertest.cc#newcode17 chrome/browser/ui/toolbar/component_toolbar_actions_browsertest.cc:17: #include "ui/gfx/image/image_skia.h" On 2015/01/29 09:42:54, Finnur wrote: > nit: ...
5 years, 10 months ago (2015-01-29 18:18:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884473006/1
5 years, 10 months ago (2015-01-29 18:20:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/39220)
5 years, 10 months ago (2015-01-29 18:26:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884473006/1
5 years, 10 months ago (2015-01-29 18:33:00 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 18:37:34 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 18:39:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea2c721a232799f8c6ea2bbef5a6f952b3684317
Cr-Commit-Position: refs/heads/master@{#313744}

Powered by Google App Engine
This is Rietveld 408576698