Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: components/navigation_interception/intercept_navigation_resource_throttle.cc

Issue 884473004: Add is_external_protocol to NavigationParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/navigation_interception/intercept_navigation_resource_throttle.cc
diff --git a/components/navigation_interception/intercept_navigation_resource_throttle.cc b/components/navigation_interception/intercept_navigation_resource_throttle.cc
index 3b151ae6005c10f9ee619f366bb9b6fe9884a7c7..4ed560c99d65f12d08171d01cb8f10d9bbab0317 100644
--- a/components/navigation_interception/intercept_navigation_resource_throttle.cc
+++ b/components/navigation_interception/intercept_navigation_resource_throttle.cc
@@ -9,11 +9,14 @@
#include "content/public/browser/child_process_security_policy.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_process_host.h"
+#include "content/public/browser/resource_context.h"
#include "content/public/browser/resource_controller.h"
#include "content/public/browser/resource_request_info.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/referrer.h"
#include "net/http/http_response_headers.h"
+#include "net/url_request/url_request_context.h"
+#include "net/url_request/url_request_job_factory.h"
#include "net/url_request/url_request.h"
#include "ui/base/page_transition_types.h"
@@ -110,13 +113,13 @@ bool InterceptNavigationResourceThrottle::CheckIfShouldIgnoreNavigation(
if (!info->GetAssociatedRenderFrame(&render_process_id, &render_frame_id))
return false;
- NavigationParams navigation_params(url,
- Referrer(GURL(request_->referrer()),
- info->GetReferrerPolicy()),
- info->HasUserGesture(),
- method == "POST",
- info->GetPageTransition(),
- is_redirect);
+ bool is_external_protocol =
+ !info->GetContext()->GetRequestContext()->job_factory()->IsHandledURL(
+ url);
+ NavigationParams navigation_params(
mnaganov (inactive) 2015/01/28 17:06:47 nit: Was this formatting done by clang-format?
+ url, Referrer(GURL(request_->referrer()), info->GetReferrerPolicy()),
+ info->HasUserGesture(), method == "POST", info->GetPageTransition(),
+ is_redirect, is_external_protocol);
BrowserThread::PostTask(
BrowserThread::UI,

Powered by Google App Engine
This is Rietveld 408576698