cc/resources/tile_manager.cc - Issue 884453003: cc: Prevent resources from being allocated for solid tiles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/tile_manager.cc

Issue 884453003: cc: Prevent resources from being allocated for solid tiles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: stop creating resources for solid tiles Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/resources/tile_manager.cc

diff --git a/cc/resources/tile_manager.cc b/cc/resources/tile_manager.cc

index da888cd77297c66a19ba39bc84425ce3abe040f4..9363f9d3116960fcb1b936b8e771f50e3540a511 100644

--- a/cc/resources/tile_manager.cc

+++ b/cc/resources/tile_manager.cc

@@ -830,7 +830,8 @@ void TileManager::UpdateTileDrawInfo(

if (analysis.is_solid_color) {

draw_info.set_solid_color(analysis.solid_color);

- resource_pool_->ReleaseResource(resource.Pass());

+ if (resource)

+ resource_pool_->ReleaseResource(resource.Pass());

} else {

draw_info.set_use_resource();

draw_info.resource_ = resource.Pass();

vmpstr 2015/01/27 18:33:27 DCHECK(resource) for the else case please.

« no previous file with comments | « cc/resources/gpu_rasterizer.cc ('k') | no next file » | no next file with comments »