Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 884453003: cc: Prevent resources from being allocated for solid tiles (Closed)

Created:
5 years, 10 months ago by hendrikw
Modified:
5 years, 10 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Prevent resources from being allocated for solid tiles If the tile is solid, don't create a resource. In tile manager, check for null resources before attempting to release. BUG=445919 Committed: https://crrev.com/66cef1db15cff142539dd5a652ae84fdce6b752b Cr-Commit-Position: refs/heads/master@{#313330}

Patch Set 1 #

Patch Set 2 : stop creating resources for solid tiles #

Total comments: 1

Patch Set 3 : add dcheck in else clause #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M cc/resources/gpu_rasterizer.cc View 1 chunk +6 lines, -10 lines 0 comments Download
M cc/resources/tile_manager.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
hendrikw
PTAL, thanks!
5 years, 10 months ago (2015-01-27 18:06:58 UTC) #2
vmpstr
lgtm https://codereview.chromium.org/884453003/diff/20001/cc/resources/tile_manager.cc File cc/resources/tile_manager.cc (right): https://codereview.chromium.org/884453003/diff/20001/cc/resources/tile_manager.cc#newcode837 cc/resources/tile_manager.cc:837: draw_info.resource_ = resource.Pass(); DCHECK(resource) for the else case ...
5 years, 10 months ago (2015-01-27 18:33:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884453003/40001
5 years, 10 months ago (2015-01-27 18:52:32 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-27 19:56:13 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 19:57:43 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/66cef1db15cff142539dd5a652ae84fdce6b752b
Cr-Commit-Position: refs/heads/master@{#313330}

Powered by Google App Engine
This is Rietveld 408576698