Issue 22157. Cancel a pending refactoring request on receiving a new one.

pkg/analysis_server/test/edit/refactoring_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.edit.refactoring;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/edit/edit_domain.dart';
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/services/index/index.dart';
 import 'package:analysis_server/src/services/index/local_memory_index.dart';
 import 'package:unittest/unittest.dart' hide ERROR;
 
 import '../analysis_abstract.dart';
+import '../mocks.dart';
 import '../reflective_tests.dart';
 
 
 main() {
   groupSep = ' | ';
   runReflectiveTests(ConvertGetterMethodToMethodTest);
   runReflectiveTests(ConvertMethodToGetterTest);
   runReflectiveTests(ExtractLocalVariableTest);
   runReflectiveTests(ExtractMethodTest);
   runReflectiveTests(GetAvailableRefactoringsTest);
@@ skipping 996 matching lines @@
         false,
         options: options).toRequest('0');
     return serverChannel.sendRequest(request);
   }
 }
 
 
 @reflectiveTest
 class RenameTest extends _AbstractGetRefactoring_Test {
   Future<Response> sendRenameRequest(String search, String newName,
-      [bool validateOnly = false]) {
+      {String id: '0', bool validateOnly: false}) {
     RenameOptions options = newName != null ? new RenameOptions(newName) : null;
     Request request = new EditGetRefactoringParams(
         RefactoringKind.RENAME,
         testFile,
         findOffset(search),
         0,
         validateOnly,
-        options: options).toRequest('0');
+        options: options).toRequest(id);
     return serverChannel.sendRequest(request);
   }
 
+  test_cancelPendingRequest() async {
+    addTestFile('''
+main() {
+  int test = 0;
+  print(test);
+}
+''');
+    // send the "1" request, but don't wait for it
+    Future<Response> futureA = sendRenameRequest('test =', 'nameA', id: '1');
+    // send the "2" request and wait for it
+    Response responseB = await sendRenameRequest('test =', 'nameB', id: '2');
+    // wait for the (delayed) "1" response
+    Response responseA = await futureA;
+    // "1" was cancelled
+    // "2" is successful
+    expect(responseA, isResponseFailure('1', RequestErrorCode.REFACTORING_REQUEST_CANCELLED));
+    expect(responseB, isResponseSuccess('2'));
+  }
+
   test_class() {
     addTestFile('''
 class Test {
   Test() {}
   Test.named() {}
 }
 main() {
   Test v;
   new Test();
   new Test.named();
@@ skipping 33 matching lines @@
   }
 
   test_class_validateOnly() {
     addTestFile('''
 class Test {}
 main() {
   Test v;
 }
 ''');
     return getRefactoringResult(() {
-      return sendRenameRequest('Test {}', 'NewName', true);
+      return sendRenameRequest('Test {}', 'NewName', validateOnly: true);
     }).then((result) {
       RenameFeedback feedback = result.feedback;
       assertResultProblemsOK(result);
       expect(feedback.elementKindName, 'class');
       expect(feedback.oldName, 'Test');
       expect(result.change, isNull);
     });
   }
 
   test_class_warning() {
@@ skipping 408 matching lines @@
 
   test_localVariable_finalCheck_shadowError() {
     addTestFile('''
 main() {
   var newName;
   int test = 0;
   print(test);
 }
 ''');
     return getRefactoringResult(() {
-      return sendRenameRequest('test = 0', 'newName', false);
+      return sendRenameRequest('test = 0', 'newName');
     }).then((result) {
       List<RefactoringProblem> problems = result.finalProblems;
       expect(problems, hasLength(1));
       assertResultProblemsError(
           problems,
           "Duplicate local variable 'newName'.");
     });
   }
 
   test_resetOnAnalysis() {
     addTestFile('''
 main() {
   int initialName = 0;
   print(initialName);
 }
 ''');
     // send the first request
     return getRefactoringResult(() {
-      return sendRenameRequest('initialName =', 'newName', true);
+      return sendRenameRequest('initialName =', 'newName', validateOnly: true);
     }).then((result) {
       RenameFeedback feedback = result.feedback;
       expect(feedback.oldName, 'initialName');
       // update the file
       modifyTestFile('''
 main() {
   int otherName = 0;
   print(otherName);
 }
 ''');
       // send the second request, with the same kind, file and offset
       return waitForTasksFinished().then((_) {
         return getRefactoringResult(() {
-          return sendRenameRequest('otherName =', 'newName', true);
+          return sendRenameRequest('otherName =', 'newName', validateOnly: true);
         }).then((result) {
           RenameFeedback feedback = result.feedback;
           // the refactoring was reset, so we don't get a stale result
           expect(feedback.oldName, 'otherName');
         });
       });
     });
   }
 
   SourceEdit _findEditWithId(SourceChange change, String id) {
@@ skipping 121 matching lines @@
   }
 
   @override
   void setUp() {
     super.setUp();
     server.handlers = [new EditDomainHandler(server),];
     createProject();
     handler = new EditDomainHandler(server);
   }
 }