Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 884413002: Upgrade Blink to milliseconds-based last modified filetimes, part 2. (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upgrade Blink to milliseconds-based last modified filetimes, part 2. With WebFileInfo::modificationTimeMS now available, have content::FileInfoToWebFileInfo() set it accordingly and alongside modificationTime. 1: [blink] add WebFileInfo::modificationTimeMS [ https://codereview.chromium.org/873723004/ ] 2: [chromium] *this one* [ https://codereview.chromium.org/884413002/ ] 3: [blink] make use of modificationTimeMS [ https://codereview.chromium.org/884393002/ ] 4: [chromium] set modificationTime to something msec-based [ https://codereview.chromium.org/862203003/ ] 5: [blink] switch to using modificationTime instead of *MS [ https://codereview.chromium.org/882343002/ ] 6: [chromium] stop setting modificationTimeMS [ https://codereview.chromium.org/890523002/ ] 7: [blink] remove modificationTimeMS [ https://codereview.chromium.org/869613005/ ] R=kinuko,jam BUG=451747 Committed: https://crrev.com/21810c1f4e59ba515a5c7fd22815fb913be48322 Cr-Commit-Position: refs/heads/master@{#314214}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M content/child/file_info_util.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
sof
Please take a look. Just tracking blink updates/changes on the chromium side; as do parts ...
5 years, 10 months ago (2015-01-30 11:19:31 UTC) #2
kinuko
lgtm
5 years, 10 months ago (2015-02-02 14:12:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884413002/1
5 years, 10 months ago (2015-02-02 14:14:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/39811)
5 years, 10 months ago (2015-02-02 14:19:57 UTC) #8
sof
On 2015/02/02 14:19:57, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 10 months ago (2015-02-02 14:32:44 UTC) #10
jam
lgtm
5 years, 10 months ago (2015-02-02 22:08:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884413002/1
5 years, 10 months ago (2015-02-02 22:18:32 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 23:08:54 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 23:09:44 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21810c1f4e59ba515a5c7fd22815fb913be48322
Cr-Commit-Position: refs/heads/master@{#314214}

Powered by Google App Engine
This is Rietveld 408576698