Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 884403002: [Password manager tests] Fix indentation bug & use subprocesses to run tests. (Closed)

Created:
5 years, 10 months ago by melandory
Modified:
5 years, 10 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password manager tests] Fix bugs & use subprocesses to run tests. Fixes indentation bug in test runner and switches from using os to subprocesses. R=vabr@chromium.org BUG=435249 Committed: https://crrev.com/5fa5a2a1173354c137769ad146f3a78fa922e3ed Cr-Commit-Position: refs/heads/master@{#313711}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -19 lines) Patch
M components/test/data/password_manager/automated_tests/run_tests.py View 4 chunks +17 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
melandory
5 years, 10 months ago (2015-01-29 09:33:33 UTC) #2
melandory
5 years, 10 months ago (2015-01-29 09:33:34 UTC) #3
vabr (Chromium)
LGTM! Thanks a lot for these improvements! (Just out of curiosity, what bugs were there ...
5 years, 10 months ago (2015-01-29 14:21:44 UTC) #4
melandory
On 2015/01/29 14:21:44, vabr (Chromium) wrote: > LGTM! > Thanks a lot for these improvements! ...
5 years, 10 months ago (2015-01-29 14:23:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884403002/20001
5 years, 10 months ago (2015-01-29 14:24:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-01-29 15:38:13 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 15:39:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fa5a2a1173354c137769ad146f3a78fa922e3ed
Cr-Commit-Position: refs/heads/master@{#313711}

Powered by Google App Engine
This is Rietveld 408576698