Source/modules/filesystem/Metadata.h - Issue 884393002: Upgrade Blink to milliseconds-based last modified filetimes, part 3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/filesystem/Metadata.h

Issue 884393002: Upgrade Blink to milliseconds-based last modified filetimes, part 3. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sof-fileinfo-modtime-in-ms-1

Patch Set: Stop using time_t over getFileModificationTime(); not sound Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/filesystem/Metadata.h

diff --git a/Source/modules/filesystem/Metadata.h b/Source/modules/filesystem/Metadata.h

index 1f08bb9775051800d885f51ea8df387d87266ceb..cfa2e329464cdc8628c370c2ebecdee8ce833efe 100644

--- a/Source/modules/filesystem/Metadata.h

+++ b/Source/modules/filesystem/Metadata.h

@@ -50,8 +50,8 @@ public:

return new Metadata(metadata->m_platformMetadata);

}

- // Needs to return epoch time in milliseconds for Date while FileMetadata's modificationTime is in seconds.

- double modificationTime() const { return m_platformMetadata.modificationTime * 1000.0; }

+ // Return Epoch time in milliseconds for Date.

+ double modificationTime() const { return m_platformMetadata.modificationTimeMS; }

unsigned long long size() const { return static_cast<unsigned long long>(m_platformMetadata.length); }

void trace(Visitor*) { }

« no previous file with comments | « Source/modules/filesystem/FileSystemCallbacks.h ('k') | Source/platform/FileMetadata.h » ('j') | no next file with comments »