Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 884313002: Fix uninitialized timestamps being passed to the gesture lib (Closed)

Created:
5 years, 10 months ago by Shecky Lin
Modified:
5 years, 10 months ago
Reviewers:
adlr, spang
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix uninitialized timestamps being passed to the gesture lib The CL corrects a bug where clock_gettime was placed in a DCHECK call and thus not executed on release builds. Contributed by sheckylin@chromium.org BUG=chrome-os-partner:35111 TEST=samus ChromeOS build Committed: https://crrev.com/c2467847c97406bc1566a6b65ba40b6284b305e9 Cr-Commit-Position: refs/heads/master@{#313634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/events/ozone/evdev/libgestures_glue/gesture_timer_provider.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
spang
lgtm
5 years, 10 months ago (2015-01-28 23:25:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884313002/1
5 years, 10 months ago (2015-01-28 23:35:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 00:19:30 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 00:21:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2467847c97406bc1566a6b65ba40b6284b305e9
Cr-Commit-Position: refs/heads/master@{#313634}

Powered by Google App Engine
This is Rietveld 408576698