mojo/public/platform/nacl/BUILD.gn - Issue 884303002: Launch nexes from mojo_shell.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/public/platform/nacl/BUILD.gn

Issue 884303002: Launch nexes from mojo_shell. Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Formatting error Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("../../mojo_sdk.gni")	5 import("../../mojo_sdk.gni")

6	6

7 mojo_sdk_source_set("system") {	7 mojo_sdk_source_set("system") {

8 sources = [	8 sources = [

9 "buffer.h",	9 "mojo_initial_handle.h",

10 "core.h",	10 "mojo_main_thunk.cc",

11 "data_pipe.h",

12 "functions.h",

13 "handle.h",

14 "macros.h",

15 "message_pipe.h",

16 ]	11 ]

17	12

18 mojo_sdk_public_deps = [ "mojo/public/c/system" ]	13 mojo_sdk_deps = [

	14 "mojo/public/c/system",

	15 "mojo/nacl:mojo",
	jamesr 2015/01/29 23:41:23 nothing in //mojo/public should depend on targets nothing in //mojo/public should depend on targets outside of //mojo/public, which AFAIKT this is. I don't see any #includes for this path - what is the intent here? Nick Bray (chromium) 2015/01/29 23:54:55 This is a library that defines the public Mojo* C Show quoted text On 2015/01/29 23:41:23, jamesr wrote: > nothing in //mojo/public should depend on targets outside of //mojo/public, > which AFAIKT this is. I don't see any #includes for this path - what is the > intent here? This is a library that defines the public Mojo* C APIs. Right now the source is being generated by a script that also generates sources that are going to be linked into mojo_shell, Chrome, the NaCl IRT etc. So.... ugly. This may be a "chat in person to try and find the right balance"-type issue.
	16 ]

19 }	17 }

OLD	NEW

« no previous file with comments | « mojo/nacl/monacl_shell.cc ('k') | mojo/public/platform/nacl/mojo_main_thunk.cc » ('j') | shell/BUILD.gn » ('J')