net/base/upload_data_stream.cc - Issue 8843: Add write and read/write support to FileStream (renamed from FileInputStream)...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/upload_data_stream.cc

Issue 8843: Add write and read/write support to FileStream (renamed from FileInputStream)... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 12 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/upload_data_stream.cc

===================================================================

--- net/base/upload_data_stream.cc (revision 4450)

+++ net/base/upload_data_stream.cc (working copy)

@@ -68,7 +68,9 @@

DCHECK(element.type() == UploadData::TYPE_FILE);

if (!next_element_stream_.IsOpen()) {

- int rv = next_element_stream_.Open(element.file_path(), false);

+ int flags = base::PLATFORM_FILE_OPEN |

+ base::PLATFORM_FILE_READ;

+ int rv = next_element_stream_.Open(element.file_path(), flags);

// If the file does not exist, that's technically okay.. we'll just

// upload an empty file. This is for consistency with Mozilla.

DLOG_IF(WARNING, rv != OK) << "Failed to open \"" <<

« no previous file with comments | « net/base/upload_data_stream.h ('k') | net/build/net.vcproj » ('j') | no next file with comments »