Issue 884283002: Fix missing header include

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 884283002: Fix missing header include (Closed)

Created:
5 years, 10 months ago by JF

Modified:
5 years, 10 months ago

Reviewers:
Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix missing header include <mutex> is already included from IceDefs.h (where GlobalLockType is defined) but <condition_variable> isn't included anywhere. It's probably included indirectly in some standard libraries and not others, causing build failures on Windows. TBR= stichnot@chromium.org BUG= none Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=84b7ed11ef339e55aa6a01453a31d604b91f0238

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/IceUtils.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Committed patchset #1 (id:1) manually as 84b7ed11ef339e55aa6a01453a31d604b91f0238 (presubmit successful).

5 years, 10 months ago (2015-01-28 22:10:40 UTC) #2

Message was sent while issue was closed.

shamecube-lgtm