Issue 884243006: Remove redundant checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 884243006: Remove redundant checks. (Closed)

Created:
5 years, 10 months ago by cmp

Modified:
5 years, 10 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, cmp-cc_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Project:
tools

Visibility:
Public.

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	tests/gclient_test.py	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (1 generated)

cmp

This fixes a spurious presubmit failure seen on https://codereview.chromium.org/891543002/ and on my dev system.

5 years, 10 months ago (2015-02-02 22:01:44 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884243006/1

5 years, 10 months ago (2015-02-02 22:06:52 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-02 22:09:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293911