Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: ui/file_manager/file_manager/foreground/js/file_selection.js

Issue 884183006: Files.app: Add UI to toggle and clear item selection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/file_selection.js
diff --git a/ui/file_manager/file_manager/foreground/js/file_selection.js b/ui/file_manager/file_manager/foreground/js/file_selection.js
index cee1cdc80d1686a0002edf3e0b39efbbbca1b07d..8217259733e0932cfe0109d4efc3e1586b80b58f 100644
--- a/ui/file_manager/file_manager/foreground/js/file_selection.js
+++ b/ui/file_manager/file_manager/foreground/js/file_selection.js
@@ -236,29 +236,6 @@ FileSelectionHandler.prototype.updateFileSelectionAsync_ = function(selection) {
if (this.selection !== selection)
return;
- // Update the label "x files selected." on the header.
- // TODO(fukino): Make presenter class which listen to the FileSelection's
- // events and update the UI components accordingly.
- if (selection.totalCount === 0) {
- this.fileManager_.ui.filesSelectedLabel.textContent = '';
- this.fileManager_.ui.filesSelectedLabel.hidden = true;
- } else {
- var text;
- if (selection.directoryCount == 0)
- text = strf('MANY_FILES_SELECTED', selection.fileCount);
- else if (selection.fileCount == 0)
- text = strf('MANY_DIRECTORIES_SELECTED', selection.directoryCount);
- else
- text = strf('MANY_ENTRIES_SELECTED', selection.totalCount);
- this.fileManager_.ui.filesSelectedLabel.textContent = text;
- this.fileManager_.ui.filesSelectedLabel.hidden = false;
- }
-
- // Hide search box if one or more items are selected.
- // TODO(fukino): Make presenter class which listen to the FileSelection's
- // events and update the UI components accordingly.
- this.fileManager_.ui.searchBox.setHidden(selection.totalCount !== 0);
-
// Sync the commands availability.
if (this.fileManager_.commandHandler)
this.fileManager_.commandHandler.updateAvailability();
« no previous file with comments | « ui/file_manager/file_manager/foreground/js/file_manager.js ('k') | ui/file_manager/file_manager/foreground/js/main_scripts.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698