Files.app: Add UI to toggle and clear item selection.

Files.app: Add UI to toggle and clear item selection.

This CL adds following operations for select items.
- Clicking icons on list view toggles selection.
- Clicking checkmarks on grid view toggles selection.
- Clicking "Cancel selection" button on the toolbar unselects all selected items.

BUG=402344
TEST=run browser_tests

Committed: https://crrev.com/57196ed2fea408d755cc8ae93a8bb977d1541c21
Cr-Commit-Position: refs/heads/master@{#314995}

[fukino, 2015-02-06 01:13:07]

fukino@chromium.org changed reviewers:
+ hirono@chromium.org

[fukino, 2015-02-06 01:13:07]

Could you take a look? Thank you!

[hirono, 2015-02-06 02:13:02]

lgtm, thanks!

https://codereview.chromium.org/884183006/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/toolbar_controller.js (right):

https://codereview.chromium.org/884183006/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/toolbar_controller.js:1: // Copyright
2014 The Chromium Authors. All rights reserved.
nit: 2015

https://codereview.chromium.org/884183006/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/toolbar_controller.js:40: * Handles
selection's change event to update the UI.
nit: @private

https://codereview.chromium.org/884183006/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/toolbar_controller.js:69: * Handles
click event for cancel button to change the selection state.
nit: @private

https://codereview.chromium.org/884183006/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/ui/file_grid.js (right):

https://codereview.chromium.org/884183006/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/file_grid.js:193: 'mouseup',
util.repeatMouseEventWithCtrlKey.bind(null, li));
Could you double check it works with touch events?

[fukino, 2015-02-06 06:46:18]

New patchsets have been uploaded after l-g-t-m from hirono@chromium.org

[fukino, 2015-02-06 06:46:42]

Thank you!

https://codereview.chromium.org/884183006/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/toolbar_controller.js (right):

https://codereview.chromium.org/884183006/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/toolbar_controller.js:1: // Copyright
2014 The Chromium Authors. All rights reserved.
On 2015/02/06 02:13:01, hirono wrote:
> nit: 2015

Done.

https://codereview.chromium.org/884183006/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/toolbar_controller.js:40: * Handles
selection's change event to update the UI.
On 2015/02/06 02:13:01, hirono wrote:
> nit: @private

Done.

https://codereview.chromium.org/884183006/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/toolbar_controller.js:69: * Handles
click event for cancel button to change the selection state.
On 2015/02/06 02:13:01, hirono wrote:
> nit: @private

Done.

https://codereview.chromium.org/884183006/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/ui/file_grid.js (right):

https://codereview.chromium.org/884183006/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/file_grid.js:193: 'mouseup',
util.repeatMouseEventWithCtrlKey.bind(null, li));
On 2015/02/06 02:13:01, hirono wrote:
> Could you double check it works with touch events?

Yes, I checked the Ctrl+touch.
It seems tap event is notified as mousedown + mouseup + click.

[fukino, 2015-02-06 06:46:43]

Thank you!

https://codereview.chromium.org/884183006/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/toolbar_controller.js (right):

https://codereview.chromium.org/884183006/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/toolbar_controller.js:1: // Copyright
2014 The Chromium Authors. All rights reserved.
On 2015/02/06 02:13:01, hirono wrote:
> nit: 2015

Done.

https://codereview.chromium.org/884183006/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/toolbar_controller.js:40: * Handles
selection's change event to update the UI.
On 2015/02/06 02:13:01, hirono wrote:
> nit: @private

Done.

https://codereview.chromium.org/884183006/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/toolbar_controller.js:69: * Handles
click event for cancel button to change the selection state.
On 2015/02/06 02:13:01, hirono wrote:
> nit: @private

Done.

https://codereview.chromium.org/884183006/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/ui/file_grid.js (right):

https://codereview.chromium.org/884183006/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/file_grid.js:193: 'mouseup',
util.repeatMouseEventWithCtrlKey.bind(null, li));
On 2015/02/06 02:13:01, hirono wrote:
> Could you double check it works with touch events?

Yes, I checked the Ctrl+touch.
It seems tap event is notified as mousedown + mouseup + click.

[fukino, 2015-02-06 06:58:28]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2015-02-06 06:58:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/884183006/40001

[commit-bot: I haz the power, 2015-02-06 07:21:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-06 07:24:02]

Patchset 3 (id:??) landed as
https://crrev.com/57196ed2fea408d755cc8ae93a8bb977d1541c21
Cr-Commit-Position: refs/heads/master@{#314995}