Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 884163004: Tiny simplification of FieldIndex::ForInObjectOffset. (Closed)

Created:
5 years, 10 months ago by Sven Panne
Modified:
5 years, 10 months ago
Reviewers:
danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Tiny simplification of FieldIndex::ForInObjectOffset. Committed: https://crrev.com/197ed66714d760a519f646e6cd0a020f49fef102 Cr-Commit-Position: refs/heads/master@{#26462}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M src/field-index-inl.h View 1 chunk +3 lines, -9 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
Sven Panne
5 years, 10 months ago (2015-02-05 13:14:57 UTC) #2
danno
https://codereview.chromium.org/884163004/diff/1/src/field-index-inl.h File src/field-index-inl.h (left): https://codereview.chromium.org/884163004/diff/1/src/field-index-inl.h#oldcode18 src/field-index-inl.h:18: return FieldIndex(true, index, false, index + 1, 0, true); ...
5 years, 10 months ago (2015-02-05 13:17:52 UTC) #3
danno
lgtm
5 years, 10 months ago (2015-02-05 13:41:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884163004/1
5 years, 10 months ago (2015-02-05 14:17:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 14:19:41 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 14:19:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/197ed66714d760a519f646e6cd0a020f49fef102
Cr-Commit-Position: refs/heads/master@{#26462}

Powered by Google App Engine
This is Rietveld 408576698