Disable LCD text when rasterizing SkPictureShader tiles.

Disable LCD text when rasterizing SkPictureShader tiles.

BUG=chromium:453299
R=reed@google.com

Committed: https://skia.googlesource.com/skia/+/3d91aad293b0f68886ed48ecfa6aa75826a27da8

[reed1, 2015-01-30 20:18:26]

This is fine, or we can have just another constructor signature that takes a
const&

https://codereview.chromium.org/884163003/diff/1/include/core/SkCanvas.h
File include/core/SkCanvas.h (right):

https://codereview.chromium.org/884163003/diff/1/include/core/SkCanvas.h#newc...
include/core/SkCanvas.h:101: @param props    If specified, these are the new
canvas surface properties.
// If NULL is passed, we use ...(?)... for the props

https://codereview.chromium.org/884163003/diff/1/include/core/SkCanvas.h#newc...
include/core/SkCanvas.h:103: explicit SkCanvas(const SkBitmap& bitmap, const
SkSurfaceProps* props = NULL);
Can't use explicit when we have more than one parameter.

https://codereview.chromium.org/884163003/diff/1/src/core/SkPictureShader.cpp
File src/core/SkPictureShader.cpp (right):

https://codereview.chromium.org/884163003/diff/1/src/core/SkPictureShader.cpp...
src/core/SkPictureShader.cpp:197: SkSurfaceProps props(0,
kUnknown_SkPixelGeometry);
// We pass kUnknown to deliberately disable LCD text, since we can't assume our
image will be opaque

[f(malita), 2015-02-01 03:46:30]

https://codereview.chromium.org/884163003/diff/1/include/core/SkCanvas.h
File include/core/SkCanvas.h (right):

https://codereview.chromium.org/884163003/diff/1/include/core/SkCanvas.h#newc...
include/core/SkCanvas.h:101: @param props    If specified, these are the new
canvas surface properties.
On 2015/01/30 20:18:26, reed1 wrote:
> // If NULL is passed, we use ...(?)... for the props

Argh. After trying to come up with a good description which doesn't leak impl
details, I'm giving up and switching to a const& ctor where I can just dodge it.
You win this time! :)

https://codereview.chromium.org/884163003/diff/1/src/core/SkPictureShader.cpp
File src/core/SkPictureShader.cpp (right):

https://codereview.chromium.org/884163003/diff/1/src/core/SkPictureShader.cpp...
src/core/SkPictureShader.cpp:197: SkSurfaceProps props(0,
kUnknown_SkPixelGeometry);
On 2015/01/30 20:18:26, reed1 wrote:
> // We pass kUnknown to deliberately disable LCD text, since we can't assume
our
> image will be opaque

Done.

[reed1, 2015-02-02 11:47:05]

VICTORY

lgtm

[f(malita), 2015-02-02 13:21:44]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2015-02-02 13:22:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/884163003/20001

[commit-bot: I haz the power, 2015-02-02 13:25:08]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3d91aad293b0f68886ed48ecfa6aa75826a27da8