Issue 884133002: Revert "Support uploading Mojo Shell on Android."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 884133002: Revert "Support uploading Mojo Shell on Android." (Closed)

Created:
5 years, 10 months ago by blundell

Modified:
5 years, 10 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Revert "Support uploading Mojo Shell on Android." This reverts commit 6cf1799caed2b018e545eef1bf499ef5b01ec731. This breaks uploading the shell on Linux on the bots, e.g.: http://build.chromium.org/p/client.mojo/builders/Mojo%20Linux/builds/1262/steps/upload%20shell%20binary/logs/stdio TBR=qsr Committed: https://chromium.googlesource.com/external/mojo/+/19e11fd328e0bd80fad53e6ef1e3d06d5fc62ae7

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -36 lines)			Patch
	M	mojo/tools/mopy/paths.py	View		1 chunk	+0 lines, -7 lines	0 comments	Download
	M	mojo/tools/upload_shell_binary.py	View		2 chunks	+14 lines, -29 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

blundell

Committed patchset #1 (id:1) manually as 19e11fd328e0bd80fad53e6ef1e3d06d5fc62ae7 (presubmit successful).

5 years, 10 months ago (2015-01-28 15:03:10 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages