Issue 884123006: Merge CSSMarkup and CSSOMUtils

Issue 884123006: Merge CSSMarkup and CSSOMUtils (Closed)

Created:
5 years, 10 months ago by rwlbuis

Modified:
5 years, 10 months ago

Reviewers:
Timothy Loh

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Merge CSSMarkup and CSSOMUtils As the FIXME says, these two files offer similar functionality, so merge them. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189601

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -156 lines)			Patch
M	Source/core/core.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/css/CSSMarkup.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	Source/core/css/CSSMarkup.cpp	View	2 chunks	+62 lines, -0 lines	0 comments	Download
D	Source/core/css/CSSOMUtils.h	View	1 chunk	+0 lines, -51 lines	0 comments	Download
D	Source/core/css/CSSOMUtils.cpp	View	1 chunk	+0 lines, -100 lines	0 comments	Download
M	Source/core/css/CSSSelector.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

rwlbuis

PTAL. I think after this we may try to use serialize* everywhere, this means outputting ...

5 years, 10 months ago (2015-02-05 23:58:49 UTC) #2

Timothy Loh

On 2015/02/05 23:58:49, rwlbuis wrote: > PTAL. I think after this we may try to ...

5 years, 10 months ago (2015-02-06 00:16:55 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884123006/1

5 years, 10 months ago (2015-02-06 00:51:42 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-06 02:15:01 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189601