Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 884123003: password_store.h: Remove unused declarations and #includes (Closed)

Created:
5 years, 10 months ago by vabr (Chromium)
Modified:
5 years, 10 months ago
Reviewers:
engedy
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

password_store.h: Remove unused declarations and #includes BUG=455750 Committed: https://crrev.com/eaf882b9cd716204f3512453ce7a56849baea248 Cr-Commit-Position: refs/heads/master@{#314831}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M components/password_manager/core/browser/password_store.h View 3 chunks +0 lines, -18 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
vabr (Chromium)
Hi Balázs, Would you mind reviewing a very simple deleter CL? As long as this ...
5 years, 10 months ago (2015-02-05 16:33:20 UTC) #2
engedy
LGTM % one line that I think we should not remove. Thanks for the cleanup! ...
5 years, 10 months ago (2015-02-05 17:18:44 UTC) #3
vabr (Chromium)
Thanks, Balázs! I have a question below. :) Vaclav https://codereview.chromium.org/884123003/diff/1/components/password_manager/core/browser/password_store.h File components/password_manager/core/browser/password_store.h (left): https://codereview.chromium.org/884123003/diff/1/components/password_manager/core/browser/password_store.h#oldcode11 components/password_manager/core/browser/password_store.h:11: ...
5 years, 10 months ago (2015-02-05 17:20:05 UTC) #4
engedy
Oh, no, I am just being colorblind. :o)
5 years, 10 months ago (2015-02-05 17:21:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884123003/1
5 years, 10 months ago (2015-02-05 17:41:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 17:45:28 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 17:46:28 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/eaf882b9cd716204f3512453ce7a56849baea248
Cr-Commit-Position: refs/heads/master@{#314831}

Powered by Google App Engine
This is Rietveld 408576698