content/browser/speech/speech_recognizer_impl_android.h - Issue 884103004: Update {virtual,override,final} to follow C++11 style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/speech/speech_recognizer_impl_android.h

Issue 884103004: Update {virtual,override,final} to follow C++11 style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/screen_orientation/screen_orientation_message_filter_android.h ('k') | content/browser/time_zone_monitor_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/speech/speech_recognizer_impl_android.h

diff --git a/content/browser/speech/speech_recognizer_impl_android.h b/content/browser/speech/speech_recognizer_impl_android.h

index cdf0b4db6d81d5abad573e16e5cc5aea6177140e..11895c441fe059256dfceac21053a55fd55a57cc 100644

--- a/content/browser/speech/speech_recognizer_impl_android.h

+++ b/content/browser/speech/speech_recognizer_impl_android.h

@@ -24,11 +24,11 @@ class CONTENT_EXPORT SpeechRecognizerImplAndroid : public SpeechRecognizer {

int session_id);

// SpeechRecognizer methods.

- virtual void StartRecognition(const std::string& device_id) override;

- virtual void AbortRecognition() override;

- virtual void StopAudioCapture() override;

- virtual bool IsActive() const override;

- virtual bool IsCapturingAudio() const override;

+ void StartRecognition(const std::string& device_id) override;

+ void AbortRecognition() override;

+ void StopAudioCapture() override;

+ bool IsActive() const override;

+ bool IsCapturingAudio() const override;

// Called from Java methods via JNI.

void OnAudioStart(JNIEnv* env, jobject obj);

@@ -53,7 +53,7 @@ class CONTENT_EXPORT SpeechRecognizerImplAndroid : public SpeechRecognizer {

std::string language, bool continuous, bool interim_results);

void OnRecognitionResultsOnIOThread(SpeechRecognitionResults const &results);

- virtual ~SpeechRecognizerImplAndroid();

+ ~SpeechRecognizerImplAndroid() override;

base::android::ScopedJavaGlobalRef<jobject> j_recognition_;

State state_;