Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 884103004: Update {virtual,override,final} to follow C++11 style. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
CC:
aboxhall+watch_chromium.org, avayvod+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, feature-media-reviews_chromium.org, jam, mlamouri+watch-geolocation_chromium.org, mlamouri+watch-sensors_chromium.org, Michael van Ouwerkerk, nasko+codewatch_chromium.org, plundblad+watch_chromium.org, riju_, timvolodine, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=nasko@chromium.org Committed: https://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e Cr-Commit-Position: refs/heads/master@{#314610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -143 lines) Patch
M content/browser/accessibility/android_granularity_movement_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/android_hit_testing_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_android.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_android.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/device_sensors/sensor_manager_android_unittest.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_android.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/geolocation/location_provider_android.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/media/android/browser_demuxer_android.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/media/android/browser_demuxer_android.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.h View 2 chunks +22 lines, -26 lines 0 comments Download
M content/browser/media/android/media_resource_getter_impl.h View 1 chunk +16 lines, -21 lines 0 comments Download
M content/browser/media/encrypted_media_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_source_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/screen_orientation/screen_orientation_delegate_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/screen_orientation/screen_orientation_message_filter_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/speech/speech_recognizer_impl_android.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/browser/time_zone_monitor_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_android.h View 2 chunks +41 lines, -40 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dcheng
5 years, 10 months ago (2015-02-04 00:50:19 UTC) #1
mlamouri (slow - plz ping)
owning a couple of files there but all lgtm
5 years, 10 months ago (2015-02-04 10:11:47 UTC) #3
nasko
LGTM
5 years, 10 months ago (2015-02-04 17:53:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884103004/1
5 years, 10 months ago (2015-02-04 18:38:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 20:03:50 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 20:04:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48d97c5da05500312e7262d32ffd42b3fbb1c38e
Cr-Commit-Position: refs/heads/master@{#314610}

Powered by Google App Engine
This is Rietveld 408576698