Issue 8841: Pass a user agent string to WinHttpOpen to set the user...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8841: Pass a user agent string to WinHttpOpen to set the user... (Closed)

Created:
12 years, 1 month ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Pass a user agent string to WinHttpOpen to set the user agent string on the session handle, which is the only way to specify the User-Agent header for HTTP CONNECT requests. This requires some refactoring. Most of the work done by Session::Init() is moved to the Session constructor. Session::Init() now only creates the primary session handle, and the call to Session::Init() is delayed to the first time we use the primary session handle (session_->internet()). R=darin BUG=552 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4114

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -60 lines)			Patch
	M	net/http/http_transaction_winhttp.cc	View	1 2 3 4	8 chunks	+61 lines, -60 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, nice work.

Expand Messages | Collapse Messages

Issue 8841: Pass a user agent string to WinHttpOpen to set the user... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Messages