Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 884073005: Create a Android Sync integration test for typed URLs (try #2) (Closed)

Created:
5 years, 10 months ago by pval...(no longer on Chromium)
Modified:
5 years, 10 months ago
Reviewers:
nyquist, Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create a Android Sync integration test for typed URLs This is a re-land of https://codereview.chromium.org/862113005/ This CL introduces JNI plumbing for one method of the FakeServer's verification API. One test (testUploadTypedUrl) has been added to use the API; it types a URL on the client and verifies that the URL was sent to the server. BUG=NONE Committed: https://crrev.com/2d2ac36ec2f96b234961e30e396f7d31a08207ce Cr-Commit-Position: refs/heads/master@{#315088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -1 line) Patch
M chrome/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/FakeServerHelper.java View 3 chunks +23 lines, -1 line 0 comments Download
M chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java View 4 chunks +38 lines, -0 lines 0 comments Download
M sync/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sync/sync_tests.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M sync/test/fake_server/android/fake_server_helper_android.h View 1 chunk +9 lines, -0 lines 0 comments Download
M sync/test/fake_server/android/fake_server_helper_android.cc View 2 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pval...(no longer on Chromium)
I uploaded a new patchset to the original issue to show what has changed: https://codereview.chromium.org/862113005/ ...
5 years, 10 months ago (2015-02-05 22:51:45 UTC) #2
nyquist
still lgtm :-) Super exciting!
5 years, 10 months ago (2015-02-05 23:17:16 UTC) #3
Nicolas Zea
LGTM!
5 years, 10 months ago (2015-02-06 01:18:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884073005/1
5 years, 10 months ago (2015-02-06 18:48:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 19:43:50 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 19:44:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d2ac36ec2f96b234961e30e396f7d31a08207ce
Cr-Commit-Position: refs/heads/master@{#315088}

Powered by Google App Engine
This is Rietveld 408576698