Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 884073003: Remove test retrying for Safari, in test scripts. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 2604 matching lines...) Expand 10 before | Expand all | Expand 10 after
2615 Future cleanup() => new Future.value(); 2615 Future cleanup() => new Future.value();
2616 2616
2617 Future<CommandOutput> runCommand(node, ProcessCommand command, int timeout) { 2617 Future<CommandOutput> runCommand(node, ProcessCommand command, int timeout) {
2618 assert(node.dependencies.length == 0); 2618 assert(node.dependencies.length == 0);
2619 return new Future.value(_archive.outputOf(command)); 2619 return new Future.value(_archive.outputOf(command));
2620 } 2620 }
2621 } 2621 }
2622 2622
2623 bool shouldRetryCommand(CommandOutput output) { 2623 bool shouldRetryCommand(CommandOutput output) {
2624 var command = output.command; 2624 var command = output.command;
2625 // We rerun tests on Safari because 6.2 and 7.1 are flaky. Issue 21434.
2626 if (command is BrowserTestCommand &&
2627 command.retry &&
2628 command.browser == 'safari' &&
2629 output is BrowserControllerTestOutcome &&
2630 output._rawOutcome != Expectation.PASS) {
2631 return true;
2632 }
2633
2634 if (!output.successful) { 2625 if (!output.successful) {
2635 List<String> stdout, stderr; 2626 List<String> stdout, stderr;
2636 2627
2637 decodeOutput() { 2628 decodeOutput() {
2638 if (stdout == null && stderr == null) { 2629 if (stdout == null && stderr == null) {
2639 stdout = decodeUtf8(output.stderr).split("\n"); 2630 stdout = decodeUtf8(output.stderr).split("\n");
2640 stderr = decodeUtf8(output.stderr).split("\n"); 2631 stderr = decodeUtf8(output.stderr).split("\n");
2641 } 2632 }
2642 } 2633 }
2643 2634
(...skipping 309 matching lines...) Expand 10 before | Expand all | Expand 10 after
2953 } 2944 }
2954 } 2945 }
2955 2946
2956 void eventAllTestsDone() { 2947 void eventAllTestsDone() {
2957 for (var listener in _eventListener) { 2948 for (var listener in _eventListener) {
2958 listener.allDone(); 2949 listener.allDone();
2959 } 2950 }
2960 _allDone(); 2951 _allDone();
2961 } 2952 }
2962 } 2953 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698