Implement chrome.platformKeys.getKeyPair().

chrome/browser/chromeos/platform_keys/platform_keys_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/platform_keys/platform_keys_service.h"
 
 #include "base/base64.h"
 #include "base/callback.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/platform_keys/platform_keys.h"
@@ skipping 52 matching lines @@
                               browser_context);
 }
 
 }  // namespace
 
 PlatformKeysService::PlatformKeysService(
     content::BrowserContext* browser_context,
     extensions::StateStore* state_store)
     : browser_context_(browser_context),
       state_store_(state_store),
+      permission_check_disabled_(false),
       weak_factory_(this) {
   DCHECK(state_store);
 }
 
 PlatformKeysService::~PlatformKeysService() {
 }
 
+void PlatformKeysService::DisablePermissionCheckForTesting() {
+  permission_check_disabled_ = true;
+}
+
 void PlatformKeysService::GenerateRSAKey(const std::string& token_id,
                                          unsigned int modulus_length,
                                          const std::string& extension_id,
                                          const GenerateKeyCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   platform_keys::subtle::GenerateRSAKey(
       token_id,
       modulus_length,
       base::Bind(&PlatformKeysService::GenerateRSAKeyCallback,
@@ skipping 116 matching lines @@
 
 void PlatformKeysService::InvalidateKey(
     const std::string& extension_id,
     const std::string& public_key_spki_der,
     const base::Callback<void(bool)>& callback,
     scoped_ptr<base::ListValue> platform_keys) {
   scoped_ptr<base::StringValue> key_value(
       GetPublicKeyValue(public_key_spki_der));
 
   size_t index = 0;
-  if (!platform_keys->Remove(*key_value, &index)) {
+  if (!platform_keys->Remove(*key_value, &index) &&
+      !permission_check_disabled_) {

[Ryan Sleevi, 2015/02/03 01:44:50]

I've read this code multiple times and I'm still confused by it.

[pneubeck (no reviews), 2015/02/03 20:15:00]

reordered to make it clearer.

     // The key is not found, so it's not valid to use it for signing.
     callback.Run(false);
     return;
   }
 
   SetPlatformKeysOfExtension(extension_id, platform_keys.Pass());
   callback.Run(true);
 }
 
 void PlatformKeysService::GotPlatformKeysOfExtension(
     const std::string& extension_id,
     const GetPlatformKeysCallback& callback,
     scoped_ptr<base::Value> value) {
   if (!value)
     value.reset(new base::ListValue);
 
   base::ListValue* keys = NULL;
   if (!value->GetAsList(&keys)) {
     LOG(ERROR) << "Found a value of wrong type.";
 
     keys = new base::ListValue;
     value.reset(keys);
   }
 
   ignore_result(value.release());
   callback.Run(make_scoped_ptr(keys));
 }
 
 }  // namespace chromeos